fix(router): prevent protocol-relative serialized URLs#69873
Closed
carrerasdarren-cell wants to merge 1 commit into
Closed
fix(router): prevent protocol-relative serialized URLs#69873carrerasdarren-cell wants to merge 1 commit into
carrerasdarren-cell wants to merge 1 commit into
Conversation
Normalize empty leading path segments when serializing UrlTrees so a RouterLink href cannot be interpreted as a scheme-relative external URL. This matches the URL parser’s existing leading-slash normalization. Fixes angular#69700
Contributor
|
I was working on this issue a few days ago. |
Member
|
We'll review #69874 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
A
UrlTreecontaining an empty leading path segment serializes with two leading slashes. Forexample, RouterLink commands such as
['/', '', 'attacker.example', 'collect']produce//attacker.example/collect. Browsers interpret thathrefas a protocol-relative external URL,even though the commands describe an internal route. Preserved or merged query parameters are
also appended to that external URL.
Issue Number: #69700
What is the new behavior?
DefaultUrlSerializerremoves empty leading path segments while serializing, so the example abovebecomes
/attacker.example/collect. This mirrors the parser's existing normalization of repeatedleading slashes and keeps the generated URL on the application's origin.
The regression test covers the command-array path and an appended query parameter. A differential
local harness also compared 4,096 ordinary command arrays with the released serializer; their
serialized output remained byte-for-byte identical.
Does this PR introduce a breaking change?
Other information
Formatting and whitespace checks pass. The focused source harness covers ordinary paths, query
parameters, fragments, named outlets, multiple empty leading segments, and browser-origin
resolution.