Skip to content

feat(devtools): show Angie on the remaining empty-state screens #69855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erkamyaman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(devtools): show Angie on the remaining empty-state screens #69855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions devtools/projects/ng-devtools/src/assets/angie-magnifying-glass.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions devtools/projects/ng-devtools/src/assets/angie-question.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 4 additions & 1 deletion .../src/lib/devtools-tabs/injector-tree/injector-providers/injector-providers.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ <h2>Providers for {{ injector().name }}</h2>
<tr mat-row *matRowDef="let row; columns: displayedColumns"></tr>
</table>
} @else {
<p class="no-providers-label">No such providers</p>
<div class="no-providers-label">
<img src="/assets/angie-orthos-back.svg" alt="Angie illustration" />
<p>No such providers</p>
</div>
}
}
16 changes: 15 additions & 1 deletion .../src/lib/devtools-tabs/injector-tree/injector-providers/injector-providers.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,22 @@
}

.no-providers-label {
padding-block: 0.5rem;
flex: 1;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
text-align: center;

img {
height: 150px;
width: auto;
margin-bottom: 0.5rem;
}

p {
margin: 0;
}
}

table {
Expand Down
7 changes: 4 additions & 3 deletions ...ols/projects/ng-devtools/src/lib/devtools-tabs/injector-tree/injector-tree.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
@if (!diDebugAPIsAvailable()) {
<p class="not-supported">
This feature is only available on version 17.0.0 or higher of Angular.
</p>
<div class="not-supported">
<img src="/assets/angie-sad.svg" alt="Angie illustration" />
<p>This feature is only available on version 17.0.0 or higher of Angular.</p>
</div>
} @else {
<div class="wrapper">
<div class="options">
Expand Down
15 changes: 15 additions & 0 deletions ...ols/projects/ng-devtools/src/lib/devtools-tabs/injector-tree/injector-tree.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,23 @@
position: relative;

.not-supported {
height: 100%;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
padding: 1rem;
text-align: center;

img {
height: 160px;
width: auto;
margin-bottom: 1rem;
}

p {
margin: 0;
}
}

.wrapper {
Expand Down
10 changes: 8 additions & 2 deletions ...tools/src/lib/devtools-tabs/profiler/recording-timeline/recording-timeline.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
@if (!hasFrames() && visualizing()) {
<p class="info">There's no information to show.</p>
<div class="info">
<img src="/assets/angie-question.svg" alt="Angie illustration" />
<p>There's no information to show.</p>
</div>
}

@if (hasFrames()) {
Expand All @@ -13,7 +16,10 @@
@let frame = this.frame();

@if (hasFrames() && !frame) {
<p class="info">Select a bar to preview a particular change detection cycle.</p>
<div class="info">
<img src="/assets/angie-magnifying-glass.svg" alt="Angie illustration" />
<p>Select a bar to preview a particular change detection cycle.</p>
</div>
} @else if (hasFrames() && frame) {
<ng-visualizer-controls
[record]="frame"
Expand Down
16 changes: 15 additions & 1 deletion ...tools/src/lib/devtools-tabs/profiler/recording-timeline/recording-timeline.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,20 @@
}

.info {
margin-top: 16px;
flex: 1;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
text-align: center;

img {
height: 160px;
width: auto;
margin-bottom: 0.5rem;
}

p {
margin: 0;
}
}
1 change: 1 addition & 0 deletions devtools/projects/ng-devtools/src/lib/devtools-tabs/router-tree/router-tree.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ <h2 class="router-title">Routes Details</h2>
</as-split>
} @else {
<div class="unsupported-version">
<img src="/assets/angie-sad.svg" alt="Angie illustration" />
<p>
Router tree visualization is available for Angular applications using the latest Angular
20.3.5 release and above. Please upgrade your application to Angular 20.3.5 or newer to use
Expand Down
8 changes: 8 additions & 0 deletions devtools/projects/ng-devtools/src/lib/devtools-tabs/router-tree/router-tree.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,12 @@
.unsupported-version {
width: 50%;
margin: auto;
text-align: center;

img {
display: block;
height: 160px;
width: auto;
margin: 0 auto 1rem;
}
}
Loading