fix(http): enable xsrf for root-provided HttpClient#69823
Open
SkyZeroZx wants to merge 2 commits into
Open
Conversation
Include the XSRF interceptor in the root token factory so the automatically provided HttpClient retains the documented default protection without requiring provideHttpClient(). Update test for the root-only provider graph and verify that withNoXsrfProtection() still disables the default header.
angular-robot
Bot
added
the
area: common/http
SkyZeroZx
commented
Jul 16, 2026
| @@ -200,7 +201,7 @@ export const HTTP_INTERCEPTORS = new InjectionToken<readonly HttpInterceptor[]>( | |||
| */ | |||
| export const HTTP_INTERCEPTOR_FNS = new InjectionToken<readonly HttpInterceptorFn[]>( | |||
| typeof ngDevMode !== 'undefined' && ngDevMode ? 'HTTP_INTERCEPTOR_FNS' : '', | |||
| {factory: () => []}, | |||
| {factory: () => [xsrfInterceptorFn]}, | |||
Contributor
Author
There was a problem hiding this comment.
It seems that when it became the default, it was omitted, or perhaps intentionally; if so, the documentation wasn't updated.
https://next.angular.dev/best-practices/security#httpclient-xsrf-csrf-security
JeanMeche
approved these changes
Jul 16, 2026
JeanMeche
added
action: merge
Contributor
Author
|
Q: Since this would also affect Angular 21.2.X, should we perform a backport or can we merge it cleanly from this PR? |
Member
|
The question you're asking is, Is that a feature fix or a security fix ? |
Contributor
Author
I would say it's both: it's a security fix in the sense that it should always have been the default according to Angular's security model, and a feature fix because this was always the default behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the XSRF interceptor in the root token factory so the automatically provided HttpClient retains the documented default protection without requiring provideHttpClient().
Update test for the root-only provider graph and verify that withNoXsrfProtection() still disables the default header.