Skip to content

fix(zone.js): vitest patching of describe/it curried calls - #69755

Merged
pkozlowski-opensource merged 1 commit into
angular:mainfrom
hawkgs:zone.js/fix-vitest-patch
Jul 22, 2026
Merged

fix(zone.js): vitest patching of describe/it curried calls#69755
pkozlowski-opensource merged 1 commit into
angular:mainfrom
hawkgs:zone.js/fix-vitest-patch

Conversation

@hawkgs

@hawkgs hawkgs commented Jul 13, 2026

Copy link
Copy Markdown
Member

Separate direct from curried calls of describe/it modifiers (direct: skip, only, etc.; curried: runIf, each, etc.) and perform the required patching to them.

Fixes: #69748

@hawkgs
hawkgs requested a review from clydin July 13, 2026 12:14
@hawkgs hawkgs added action: review The PR is still awaiting reviews from at least one requested reviewer area: zones Issues related to zone.js labels Jul 13, 2026
@ngbot ngbot Bot added this to the Backlog milestone Jul 13, 2026
@pullapprove
pullapprove Bot requested a review from crisbeto July 13, 2026 12:14
@hawkgs
hawkgs force-pushed the zone.js/fix-vitest-patch branch 2 times, most recently from 25ce49d to ebf0e2a Compare July 13, 2026 12:40
@hawkgs
hawkgs removed the request for review from crisbeto July 13, 2026 12:42
@pullapprove
pullapprove Bot requested a review from crisbeto July 13, 2026 12:43
@hawkgs
hawkgs removed the request for review from crisbeto July 13, 2026 12:46
@pullapprove
pullapprove Bot requested a review from crisbeto July 13, 2026 12:46
@hawkgs
hawkgs requested review from alan-agius4 and removed request for crisbeto July 13, 2026 12:48
@pullapprove
pullapprove Bot requested a review from crisbeto July 13, 2026 12:48
@hawkgs
fix(zone.js): vitest patching of describe/it curried calls
63dc2dc 
Separate direct from curried calls of `describe`/`it` modifiers
(direct: `skip`, `only`, etc.; curried: `runIf`, `each`, etc.)
and perform the required patching to them.

Fixes: angular#69748
@hawkgs
hawkgs force-pushed the zone.js/fix-vitest-patch branch from ebf0e2a to 63dc2dc Compare July 13, 2026 12:51
@clydin clydin added the target: patch This PR is targeted for the next patch release label Jul 20, 2026
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 20, 2026
@pkozlowski-opensource
pkozlowski-opensource merged commit e23541b into angular:main Jul 22, 2026
27 checks passed
@pkozlowski-opensource

pkozlowski-opensource commented Jul 22, 2026

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

@hawkgs
hawkgs deleted the zone.js/fix-vitest-patch branch July 27, 2026 08:35
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Oct 18, 2026

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes
@alan-agius4 alan-agius4 alan-agius4 approved these changes
@clydin clydin clydin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

zone.js vitest-patch breaks all describe/it modifiers: describe.skip runs the suite, it.skip/it.todo silently vanish, .each is miswired

6 participants

@hawkgs @pkozlowski-opensource @crisbeto @alan-agius4 @clydin @JeanMeche