Skip to content

fix(docs-infra): increase SSR fetch limit to prevent 404 on page reload #69377 - #69379

Merged
thePunderWoman merged 1 commit into
angular:mainfrom
rudzikdawid:fix/404-docs
Jun 17, 2026
Merged

fix(docs-infra): increase SSR fetch limit to prevent 404 on page reload #69377#69379
thePunderWoman merged 1 commit into
angular:mainfrom
rudzikdawid:fix/404-docs

Conversation

@rudzikdawid

@rudzikdawid rudzikdawid commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Directly navigating to or refreshing (F5) certain documentation pages with large content, such as /guide/aria/combobox and /guide/aria/autocomplete, results in a 404 error page. This occurs because the content payload exceeds the default HTTP fetch response size limit during Server-Side Rendering (SSR).

Issue Number: #69377

What is the new behavior?

This PR resolves the issue by explicitly providing larger limit 2MB (2 * 1024 * 1024). The affected pages now render successfully on initial load and after a hard refresh without redirecting to 404.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

hotfix

@pullapprove
pullapprove Bot requested a review from josephperrott June 16, 2026 16:34
@angular-robot angular-robot Bot added the area: docs-infra Angular.dev application and infrastructure label Jun 16, 2026
@ngbot ngbot Bot added this to the Backlog milestone Jun 16, 2026
JeanMeche
JeanMeche requested changes Jun 16, 2026
View reviewed changes
Comment thread adev/src/app/app.config.server.ts Outdated
josephperrott
josephperrott requested changes Jun 16, 2026
View reviewed changes
Comment thread adev/src/app/app.config.server.ts Outdated
@github-actions

github-actions Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Deployed adev-preview for f91d309 to: https://ng-dev-previews-fw--pr-angular-angular-69379-adev-prev-p0ejc77s.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@rudzikdawid

rudzikdawid commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@JeanMeche, @josephperrott thanks for the review. The fixes have been pushed!

josephperrott
josephperrott approved these changes Jun 16, 2026
View reviewed changes

@josephperrott josephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rudzikdawid
fix(docs-infra): increase SSR fetch limit to prevent 404 on page reload
f91d309 
Navigating to specific ARIA guide pages directly or via hard refresh
causes a 404 error because the payload exceeds the default SSR fetch
limit. This commit increases the maxResponseBodySize to 2MB.
@angular-robot
angular-robot Bot requested a review from AndrewKushnir June 17, 2026 05:33
@rudzikdawid

rudzikdawid commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@AndrewKushnir Just a heads-up that I performed a force push on this PR to resolve linting issues

jerz4
jerz4 approved these changes Jun 17, 2026
View reviewed changes

@jerz4 jerz4 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

m-aciek
m-aciek approved these changes Jun 17, 2026
View reviewed changes

@m-aciek m-aciek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; follow-up: could integration tests check for exceeding the limit?

@alan-agius4 alan-agius4 linked an issue Jun 17, 2026 that may be closed by this pull request
docs(adev): 404 error on page refresh (F5) for specific ARIA guides (combobox, autocomplete) #69377
Closed
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 17, 2026
@alan-agius4
alan-agius4 removed the request for review from AndrewKushnir June 17, 2026 09:59
@thePunderWoman
thePunderWoman merged commit 02d6b43 into angular:main Jun 17, 2026
26 checks passed
@thePunderWoman

thePunderWoman commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes
@josephperrott josephperrott josephperrott approved these changes
@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes
+2 more reviewers
@m-aciek m-aciek m-aciek approved these changes
@jerz4 jerz4 jerz4 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

docs(adev): 404 error on page refresh (F5) for specific ARIA guides (combobox, autocomplete)

8 participants

@rudzikdawid @thePunderWoman @JeanMeche @m-aciek @josephperrott @jerz4 @AndrewKushnir @alan-agius4