Repository navigation
fix(compiler): report error for property/event bindings on ng-content - #68715
toha-marko wants to merge 1 commit into
Conversation
angular-robot
Bot
added
the
area: compiler
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Previously, adding property bindings like [foo]="bar" or event bindings like (click)="handler()" to <ng-content> was silently ignored. These bindings have no effect since ng-content is not a real DOM element. This commit adds a compile-time error to warn the developer. Fixes angular#24259
729212e to
f825e73
Compare
|
Minimally, this would require a migration to remove those invalid properties in order to land it. Given that the bug report has no upvotes or activity in almost a decade, I have to question whether this is worth it. |
|
Is this maybe more appropriate as a template diagnostic or eslint? Breaking compilation on something entirely innocuous seems maybe incorrect. |
|
Hi @atscott, thanks for the review and for clarifying this! You are completely right — since these bindings are currently silently ignored, throwing a hard compiler error now would break existing builds, which makes it a breaking change. Since it's a harmless issue at runtime, breaking the compilation might be an overkill and require unnecessary migration efforts. I'm happy to close this PR and look into contributing a rule to Before I close it though, do you think implementing this as a template diagnostic in the core compiler is still worth pursuing, or do you feel ESLint is the best place for this kind of check? |
|
Yeah, +1 on a linting rule. |
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Previously, adding property bindings like
[foo]="bar"or event bindings like(click)="handler()"to<ng-content>was silently ignored. These bindings have no effect since ng-content is not a real DOM element. This commit adds a compile-time error to warn the developer.Fixes #24259
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Adding property/event bindings to
<ng-content>is silently ignored by the compiler.Issue Number: #24259
What is the new behavior?
The compiler now reports an error when property or event bindings are found on
<ng-content>.