Skip to content

refactor(devtools): drop explicit OnPush change detection strategy#67855

Merged
leonsenft merged 1 commit into
angular:mainfrom
hawkgs:devtools/drop-explicit-onpush
Mar 25, 2026
Merged

refactor(devtools): drop explicit OnPush change detection strategy#67855
leonsenft merged 1 commit into
angular:mainfrom
hawkgs:devtools/drop-explicit-onpush

Conversation

@hawkgs

@hawkgs hawkgs commented Mar 25, 2026

Copy link
Copy Markdown
Member

Drop explicit ChangeDetectionStrategy.OnPush from the apps since it's now the default.

Related to: #67687

Drop explicit `ChangeDetectionStrategy.OnPush` from the apps since it's now the default.
@hawkgs
hawkgs requested review from JeanMeche and dgp1130 March 25, 2026 09:50
@ngbot ngbot Bot added this to the Backlog milestone Mar 25, 2026

@JeanMeche JeanMeche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hawkgs hawkgs added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Mar 25, 2026
@hawkgs
hawkgs removed the request for review from dgp1130 March 25, 2026 12:38
@dgp1130

dgp1130 commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Do we also need to (probably in a separate PR) update the changeDetection option for the generator schematic? OnPush shouldn't emit anything and Eager should explicitly emit ChangeDetectionStrategy.Eager.

@leonsenft
leonsenft merged commit 0ad18ee into angular:main Mar 25, 2026
24 checks passed
@leonsenft

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@hawkgs
hawkgs deleted the devtools/drop-explicit-onpush branch March 26, 2026 09:50
@hawkgs

hawkgs commented Mar 26, 2026

Copy link
Copy Markdown
Member Author

@dgp1130, yeah, I guess we should handle that in the CLI repo.

Edit: Has already been addressed in angular/angular-cli@b3d838d and angular/angular-cli@6572a69

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: devtools target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants