Repository navigation
refactor(forms): make markAsTouched() touch all descendants by default - #67453
Conversation
leonsenft
added
area: forms
target: patch
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
JeanMeche
added
the
merge: caretaker note
|
Presubmit failures are unrelated, this is good to go |
df8423f to
5c1c201
Compare
atscott
added
action: cleanup
`markAsTouched()` now marks all descendants as touched. In general this
method is called when controls update the model. Most controls update
leaf nodes, in which case this change has no effect.
Marking all descendants allows triggering validation for subsections of
a form, independently from having to call `submit()` on the entire form.
`markAsTouched()` now accepts a `MarkAsTouchedOptions` parameter, which
includes a `skipDescendants` property. This can be used mark only the
receiving field as touched: `node.markAsTouched({skipDescendants: true})`.
5c1c201 to
8f9f65c
Compare
leonsenft
added
merge: caretaker note
|
Note for caretaker: ready for merge again |
|
This PR has some conflicts with 21.2.x |
leonsenft
added
target: minor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
markAsTouched()now marks all descendants as touched. In general this method is called when controls update the model. Most controls update leaf nodes, in which case this change has no effect.Marking all descendants allows triggering validation for subsections of a form, independently from having to call
submit()on the entire form.markAsTouched()now accepts aMarkAsTouchedOptionsparameter, which includes askipDescendantsproperty. This can be used mark only the receiving field as touched:node.markAsTouched({skipDescendants: true}).