feat(forms): support binding null to number input#66917
Draft
mmalerba wants to merge 3 commits intoangular:mainfrom
Draft
feat(forms): support binding null to number input#66917mmalerba wants to merge 3 commits intoangular:mainfrom
mmalerba wants to merge 3 commits intoangular:mainfrom
Conversation
Reoves the `parseErrors` property on `FormUiControl` and instead introduces a new utility `transformedValue` that automatically handles synchronizing the raw value and model value using the given `parse` and `format` functions. It also automates the reporting of `parseErrors` to the `FormField`, simplifying the API surface
Supports binding `null` to a `<input type=number>`. - Treats a model value of `null` the same as a model value of `NaN` - When the user clears the input, reports `null` rather than `NaN` - When the user types an invalid number, model does not update, raises an error via the parse errors mechanism
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports binding
nullto a<input type=number>.nullthe same as a model value ofNaNnullrather thanNaNan error via the parse errors mechanism