docs: improve type safety in custom validator documentation#66889
Open
MeAkib wants to merge 1 commit intoangular:mainfrom
Open
docs: improve type safety in custom validator documentation#66889MeAkib wants to merge 1 commit intoangular:mainfrom
MeAkib wants to merge 1 commit intoangular:mainfrom
Conversation
Replace `field: any` with proper SchemaPath typing in Signal Forms custom validation examples to match built-in validator patterns. fixes: angular#66887
JeanMeche
reviewed
Feb 3, 2026
Comment on lines
+498
to
+501
| function url<TValue extends string, TPathKind extends PathKind = PathKind.Root>( | ||
| path: SchemaPath<TValue, SchemaPathRules.Supported, TPathKind>, | ||
| options?: {message?: string}, | ||
| ) { |
Member
There was a problem hiding this comment.
Any reason for not going with following?
Suggested change
| function url<TValue extends string, TPathKind extends PathKind = PathKind.Root>( | |
| path: SchemaPath<TValue, SchemaPathRules.Supported, TPathKind>, | |
| options?: {message?: string}, | |
| ) { | |
| function url( | |
| path: SchemaPath<string>, | |
| options?: {message?: string}, | |
| ) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
field: anywith proper SchemaPath typing in Signal Forms custom validation examples to match built-in validator patterns.fixes: #66887