refactor(common): improve image directive typings#66850
Open
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
Open
refactor(common): improve image directive typings#66850SkyZeroZx wants to merge 1 commit intoangular:mainfrom
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
Conversation
angular-robot
bot
added
the
area: common
mmalerba
requested changes
Feb 2, 2026
| ]); | ||
| } | ||
| if (changes['ngSrc'] && !changes['ngSrc'].isFirstChange()) { | ||
| if (changes.ngSrc && !changes.ngSrc.isFirstChange()) { |
Contributor
There was a problem hiding this comment.
Changing these from quoted to unquoted reads likely breaks apps that are using the closure compiler
Add image directive typings to improve type safety and removes an unused parameter from the observer registration.
SkyZeroZx
force-pushed
the
refactor/img-unsued
branch
from
a575a3d to
14803b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add image directive typings to improve type safety and removes an unused parameter from the observer registration.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
I don't think it's considered a breaking change since we treat the directives as Final Class