Repository navigation
fix(http): correctly parse ArrayBuffer and Blob in transfer cache - #66835
Conversation
4602af2 to
d20b5a6
Compare
|
@SkyZeroZx is this ready for review? |
I think so, updated |
d20b5a6 to
96967b2
Compare
Encodes arraybuffer and blob response bodies as base64 when storing in the transfer cache, ensuring correct retrieval and usage on the client side. Fixes angular#66827
96967b2 to
469db27
Compare
JoostK
left a comment
There was a problem hiding this comment.
I think this approach is reasonable. It may be worth considering feature-detecting the availability of UInt8Array.{to,from}Base64()—or using Buffer.toString('base64') in Node < v25—to adopt platform-native encoding/decoding when available. In theory that should be more efficient as it avoids the intermediary "byte string", but I don't know if it makes an actual difference in practice.
I think the same, we can do it in a follow-up PR since in my local tests I found a significant speed difference |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Encodes arraybuffer and blob response bodies as base64 when storing in the transfer cache, ensuring correct retrieval and usage on the client side
Fixes #66827
What is the current behavior?
Issue Number: #66827
I can also reproduce this issue using
protobufjsin https://github.com/SkyZeroZx/issue-buffer-blobDoes this PR introduce a breaking change?
Other information