fix(compiler): better types for a few expression AST nodes#66206
Merged
kirjs merged 1 commit intoangular:mainfrom Jan 6, 2026
Merged
fix(compiler): better types for a few expression AST nodes#66206kirjs merged 1 commit intoangular:mainfrom
kirjs merged 1 commit intoangular:mainfrom
Conversation
crisbeto
added
action: review
angular-robot
bot
added
the
area: compiler
We had `any` types for `LiteralArray.expressions`, `Chain.expressions`, `BindingPipe.args`, `LiteralPrimitive.value` and `LiteralMap.values`. These changes add proper types to them.
crisbeto
force-pushed
the
improve-ast-types
branch
from
dd8e8d4 to
aa51f94
Compare
JeanMeche
approved these changes
Jan 4, 2026
JeanMeche
added
action: merge
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had
anytypes forLiteralArray.expressions,Chain.expressions,BindingPipe.args,LiteralPrimitive.valueandLiteralMap.values. These changes add proper types to them.