fix(compiler): produce accurate span for typeof and void expressions#66189
Merged
kirjs merged 1 commit intoangular:mainfrom Jan 7, 2026
Merged
fix(compiler): produce accurate span for typeof and void expressions#66189kirjs merged 1 commit intoangular:mainfrom
kirjs merged 1 commit intoangular:mainfrom
Conversation
crisbeto
added
action: review
angular-robot
bot
added
the
area: compiler
Fixes that the `typeof` and `void` expressions were starting their spans from the expression start, rather than the keyword. Fixes angular#66174.
crisbeto
force-pushed
the
66174/void-spans
branch
from
c23634a to
2e15e73
Compare
JeanMeche
approved these changes
Jan 2, 2026
crisbeto
added
action: merge
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that the
typeofandvoidexpressions were starting their spans from the expression start, rather than the keyword.Fixes #66174.