refactor(router): Build out integration with browser Navigation API #64905
+817
−496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the integration with the browser navigation API is built out, we will want to have the types available
angular-robot
bot
added
area: build & ci
atscott
force-pushed
the
morenavigationcommits
branch
from
6808cb3 to
38bafb1
Compare
This further builds out the Router integration with the platform Navigation API. Key features in this state include: * History restoration via direct platform APIs rather than markers left on `history.state`. This means more guaranteed correctness and less internal code to compute traversal restorations. * Ability to observe navigations triggered outside the Router APIs. Practically speaking, this means some navigations can be performed through the platform rather than requiring `Router.navigate`. Note that because the `NavigateEvent` is never intercepted at this point of the implementation, regular anchor tags cannot be used because they will still trigger a popstate navigation. This implementation does _not_ intercept the `NavigateEvent` but future iterations should. By omitting the interception, we are missing out on features such as: * Platform-supported scroll and focus reset * Holding the navigate event open for the duration of the router navigation, allowing for a visual loading indicator in the browser * Support for intercepting navigations from regular anchor tags (e.g. not `RouterLink`s) and converting those to SPA navigations.
atscott
force-pushed
the
morenavigationcommits
branch
from
38bafb1 to
0b82847
Compare
josephperrott
approved these changes
Nov 5, 2025
Comment on lines
+24
to
+25
| "tslib": "^2.3.0", | ||
| "@types/dom-navigation": "^1.0.5" |
There was a problem hiding this comment.
Since these types are not exported in the public API, and don't show up in the package anywhere as they are built-ins in the browser, you can depend on it under devDependencies
Suggested change
| "tslib": "^2.3.0", | |
| "@types/dom-navigation": "^1.0.5" | |
| "tslib": "^2.3.0" | |
| }, | |
| "devDependencies": { | |
| "@types/dom-navigation": "^1.0.5" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further builds out the Router integration with the platform
Navigation API. Key features in this state include:
history.state. This means more guaranteed correctness and lessinternal code to compute traversal restorations.
Practically speaking, this means some navigations can be performed
through the platform rather than requiring
Router.navigate. Notethat because the
NavigateEventis never intercepted at this point ofthe implementation, regular anchor tags cannot be used because they
will still trigger a popstate navigation.
This implementation does not intercept the
NavigateEventbut futureiterations should. By omitting the interception, we are missing out on
features such as:
navigation, allowing for a visual loading indicator in the browser
(and ability to cancel navigation from the UI)
not
RouterLinks) and converting those to SPA navigations.Reviewer note: As with prior changes to support the Navigation API, this affects neither the behavior nor the code size of any existing, non-tree shakeable default code paths.