refactor(forms): allow FieldTree of recursive type #64904
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
area: forms
target: rc
Adjusts our typings to work better with recursive types and avoid infinite recursion in the type system.
leonsenft
approved these changes
Nov 5, 2025
| // type RecursiveType = (number | RecursiveType)[] | ||
| // type Test = FieldTree<RecursiveType> // Infinite type recursion if condition distributes. | ||
| // ``` | ||
| (TValue & {} extends Array<infer U> |
There was a problem hiding this comment.
This is the same issue we encountered with the compat types right? Is there a reason we solved it here using TValue & {} extends Array<infer U> instead of [TValue] extends [Array<infer U>] like we did with the compat types and is recommended in the linked docs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts our typings to work better with recursive types and avoid infinite recursion in the type system.