Skip to content

refactor(forms): add better support for Object.keys and Symbol.iterator #64903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(forms): add better support for Object.keys and Symbol.iterator #64903

wants to merge 1 commit into from
+93 −3

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Nov 5, 2025

Improves support for using Object.keys (and related methods) and Symbol.iterator to work with a FieldTree of unknown shape.

@mmalerba mmalerba requested review from kirjs and leonsenft November 5, 2025 00:44
@mmalerba mmalerba added area: forms target: rc This PR is targeted for the next release-candidate forms: signals labels Nov 5, 2025
@ngbot ngbot bot modified the milestone: Backlog Nov 5, 2025
@mmalerba
refactor(forms): add better support for Object.keys and Symbol.iterator
c945e07 
Improves support for using `Object.keys` (and related methods) and
`Symbol.iterator` to work with a `FieldTree` of unknown shape.
kirjs
kirjs approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

@pullapprove pullapprove bot requested a review from kirjs November 5, 2025 15:44
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 5, 2025
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker labels Nov 5, 2025
@mmalerba mmalerba removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 5, 2025
leonsenft
leonsenft approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@leonsenft leonsenft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@pullapprove pullapprove bot requested a review from thePunderWoman November 5, 2025 18:19
thePunderWoman
thePunderWoman approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

and what a public-api that is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@leonsenft leonsenft leonsenft approved these changes

@kirjs kirjs Awaiting requested review from kirjs

Assignees

No one assigned

Labels

area: forms forms: signals target: rc This PR is targeted for the next release-candidate

Projects

Experimental Signal Forms
Status: No status

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@mmalerba @thePunderWoman @leonsenft @kirjs