docs: use self-closing component tags and perform minor cleanup #64880
+118
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeAkib
reviewed
Nov 4, 2025
JeanMeche
reviewed
Nov 4, 2025
|
|
||
| @Component({ | ||
| selector: 'app-housing-location', | ||
| imports: [RouterModule], |
There was a problem hiding this comment.
If we do this change we'll want to update the instructions in adev/src/content/tutorials/first-app/steps/10-routing/README.md
There was a problem hiding this comment.
You're right, I was wondering if replacing the tutorial or adding a note like this would be better?
What do you think?
Note: Importing RouterModule provides all the router directives including RouterOutlet, RouterLink and RouterLinkActive.
There was a problem hiding this comment.
I think we'll want to be explicit on the imports. The less we talk about ngModules the better.
There was a problem hiding this comment.
Updated, I also updated the syntax highlighting so that the provided examples are easier to read.
JeanMeche
reviewed
Nov 4, 2025
…ctives, and fix syntax highlighting
SkyZeroZx
force-pushed
the
docs/tutorial
branch
from
ae29f60 to
489308c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information