Should we go with vitest from the start ?

I just forked this off of the adev setup. I can try to get it to work with vitest, but not sure if we have support for that in our current bazel setup (or if I know what I'm doing enough to get it working)

For this new application, I'd suggest avoiding Karma. Setting up Vitest with JSDOM should be relatively straightforward as it's already done for new application.

Honestly, I think it might have been better to generate a fresh app using the Angular CLI and then add the Bazel bits, rather than copying the 'adev' setup, which now needs to be cleaned up

Ok, I pushed a new commit where I just based it on a fresh ng new app. I can run it, but there's still a few problems:

• vscode shows red squiggles for the import from @angular/core "Cannot find module '@angular/core' or its corresponding type declarations.ts(2307)" (resulting in everything being any type
• tests don't build, something is looking for karma (I'm probably using the wrong bazel rule)
• couldn't get SSR to work so I just generated an app without it (failed to build due to some type errors)

Happy to that a look and push if that's fine for you, for vitest it's the same ng_test rules but you do need to have the karma depedencies installed regardless for now. (Requires a cleanup in the build rule).

Ah ok, I had a similar issue with zone.js where it was required for one of the build rules even though it was unused. I got the tests building now at least, but they fail to run because they can't find tsconfig.app.json. @angular/core still shows up with red squiggles too (but not other packages like @angular/router for some reason). Feel free to take a look and push up commits if that's easier.