docs: aria autocomplete component guide (WIP) #64864
Draft
+927
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencodezen
added
action: discuss
area: docs
angular-robot
bot
added
detected: feature
bencodezen
changed the title
bencodezen
changed the title
bencodezen
removed
area: build & ci
bencodezen
removed
detected: feature
bencodezen
force-pushed
the
docs/aria-autocomplete-guide
branch
from
f24be59 to
92417e9
Compare
|
Deployed adev-preview for 56941bd to: https://ng-dev-previews-fw--pr-angular-angular-64864-adev-prev-xlucaspn.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
bencodezen
force-pushed
the
docs/aria-autocomplete-guide
branch
from
92417e9 to
56941bd
Compare
JeanMeche
reviewed
Nov 3, 2025
| : []), | ||
| : [ | ||
| { | ||
| label: 'Angular Aria', |
There was a problem hiding this comment.
We'll want to have the status: 'new'
JeanMeche
reviewed
Nov 3, 2025
| @@ -0,0 +1,14 @@ | |||
| <!doctype html> | |||
There was a problem hiding this comment.
I don't think we need that index.html
JeanMeche
reviewed
Nov 3, 2025
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| }) | ||
| export class App { | ||
| popover = viewChild<ElementRef>('popover'); |
There was a problem hiding this comment.
Suggested change
| popover = viewChild<ElementRef>('popover'); | |
| popover = viewChild<ElementRef<HTMLDivElement>>.required('popover'); |
Using required will allow us to remove the type assertion
JeanMeche
reviewed
Nov 3, 2025
Comment on lines
+25
to
+26
| listbox = viewChild<Listbox<any>>(Listbox); | ||
| combobox = viewChild<Combobox<any>>(Combobox); |
There was a problem hiding this comment.
Suggested change
| listbox = viewChild<Listbox<any>>(Listbox); | |
| combobox = viewChild<Combobox<any>>(Combobox); | |
| listbox = viewChild.required<Listbox<unknown>>(Listbox); | |
| combobox = viewChild.required<Combobox<unknown>>(Combobox); |
JeanMeche
reviewed
Nov 3, 2025
Comment on lines
+1
to
+14
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <base href="/" /> | ||
|
|
||
| <title>Autocomplete - Auto-Select Mode</title> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <app-root></app-root> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
iirc we don't need that index.html file if we don't those e2e tests.
Same for the main.ts below
For the context, we don't compile a new file but just the component itself.
JeanMeche
reviewed
Nov 4, 2025
|
|
||
| Autocomplete combines a text input with a dynamic suggestion list that narrows down options based on user input. Users can type to filter options, navigate suggestions with keyboard arrows, and select values from the list. This pattern is particularly useful for forms with many predefined options, such as state selection, product search, or user lookup. | ||
|
|
||
| <docs-code-multifile preview hideCode path="adev/src/content/examples/aria/autocomplete/src/basic/app/app.component.ts"> |
There was a problem hiding this comment.
The current behavior with hideCode is weird. I just want to confirm that we indeed want hideCode (and I can take care of fixing it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information