refactor(http): simplifies destruction tracking using destroyed property #64856
+1
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: common/http
SkyZeroZx
changed the title
MeAkib
reviewed
Nov 3, 2025
SkyZeroZx
force-pushed
the
refactor/add-more-refactor-http
branch
from
3d9a564 to
4a08f8c
Compare
JeanMeche
reviewed
Nov 3, 2025
Comment on lines
-66
to
-72
| private destroyed = false; | ||
|
|
||
| constructor() { | ||
| this.destroyRef.onDestroy(() => { | ||
| this.destroyed = true; | ||
| }); | ||
| } |
There was a problem hiding this comment.
Can we just keep this and those the rest of the changes. We won't be accepting publicAPI changes outside of the breaking change window.
Replaces the manual destroyed state with destroyed property
SkyZeroZx
force-pushed
the
refactor/add-more-refactor-http
branch
from
4a08f8c to
068476e
Compare
SkyZeroZx
changed the title
JeanMeche
approved these changes
Nov 3, 2025
JeanMeche
added
action: merge
thePunderWoman
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(http): simplifies destruction tracking using destroyed property
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information