Skip to content

refactor(core): render additional WAI-ARIA 1.3 property bindings as attributes #64850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(core): render additional WAI-ARIA 1.3 property bindings as attributes #64850

wants to merge 1 commit into from

Conversation

@d-koppenhagen
Copy link
Contributor

@d-koppenhagen d-koppenhagen commented Nov 2, 2025 •
edited
Loading

Support additional ARIA properties from Accessible Rich Internet Applications (WAI-ARIA) version 1.3.

attribute property
aria-activedescendant ariaActiveDescendantElement
aria-colindextext ariaColIndexText
aria-controls ariaControlsElements
aria-describedby ariaDescribedByElements
aria-description ariaDescription
aria-details ariaDetailsElements
aria-errormessage ariaErrorMessageElements
aria-flowto ariaFlowToElements
aria-labelledby ariaLabelledByElements
aria-owns ariaOwnsElements
aria-rowindextext ariaRowIndexText

closes #64847

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently the attributes / properties are not supported.
Therefore, an attribute binding must be used:

<label>
  My Input
  <input type="search" [attr.aria-description]="myDescription()" />
</label>

Issue Number: #64847

What is the new behavior?

<label>
  My Input
  <input type="search"
-   [attr.aria-description]="myDescription()"
+   [attr.ariaDescription]="myDescription()"
  />
</label>

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Refer to https://www.w3.org/TR/wai-aria-1.3/#accessibilityroleandproperties-correspondence

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Nov 2, 2025
@ngbot ngbot bot added this to the Backlog milestone Nov 2, 2025
@JeanMeche JeanMeche requested review from JeanMeche and leonsenft and removed request for jelbourn, josephperrott and mmalerba November 2, 2025 07:46
JeanMeche
JeanMeche reviewed Nov 2, 2025
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reviewing #63748, we were discussing with @leonsenft the issue of attributes that don't have a matching property.

As is, the change does add support for the new attributes but also introduces false positives for properties that don't match their attribute leading to runtime errors despite a successful compilation.

We probably need to rework a bit how the registry works (and probably deprecate binding to properties and to stick only to binding the attributes directly).

josephperrott
josephperrott requested changes Nov 3, 2025
View reviewed changes
leonsenft
leonsenft requested changes Nov 3, 2025
View reviewed changes
@JeanMeche
Copy link
Member

JeanMeche commented Nov 4, 2025

Actually I just talk a bit with @leonsenft we should be good to go. (I must understood the change in #63925).

Can you make sure to take into acount the suggestions from Joey and rework the commit message to refactor so we can ship that change in v21.0. (a feat commit can only land in the next minor).

@d-koppenhagen
refactor(core): render additional WAI-ARIA 1.3 property bindings as a…
2cbb145 
…ttributes

Support additional ARIA properties from Accessible Rich Internet Applications (WAI-ARIA) version 1.3.

| attribute | property |
|-----------|----------|
| `aria-activedescendant`           | `ariaActiveDescendantElement` |
| `aria-colindextext`           | `ariaColIndexText` |
| `aria-controls`           | `ariaControlsElements ` |
| `aria-describeyby`           | `ariaDescribedByElements ` |
| `aria-description`           | `ariaDescription` |
| `aria-details`           | `ariaDetailsElements ` |
| `aria-errormessage`           | `ariaErrorMessageElements ` |
| `aria-flowto`           | `ariaFlowToElements ` |
| `aria-labelledby`           | `ariaLabelledByElements ` |
| `aria-owns`           | `ariaOwnsElements ` |
| `aria-rowindextext`           | `ariaRowIndexText ` |

closes angular#64847
@d-koppenhagen d-koppenhagen force-pushed the feat-support-more-aria-prop-bindings branch from eec793f to 2cbb145 Compare November 4, 2025 17:47
@JeanMeche JeanMeche changed the title feat(core): render additional WAI-ARIA 1.3 property bindings as attributes refactor(core): render additional WAI-ARIA 1.3 property bindings as attributes Nov 4, 2025
@JeanMeche JeanMeche requested a review from leonsenft November 4, 2025 18:31
josephperrott
josephperrott approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@leonsenft leonsenft leonsenft approved these changes

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

area: core Issues related to the framework runtime detected: feature PR contains a feature commit

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Add support to render ariaDescription property binding as Attribute aria-description

4 participants

@d-koppenhagen @JeanMeche @leonsenft @josephperrott