refactor(compiler-cli): remove deep imports from compiler-cli#64732
Open
JeanMeche wants to merge 2 commits intoangular:mainfrom
Open
refactor(compiler-cli): remove deep imports from compiler-cli#64732JeanMeche wants to merge 2 commits intoangular:mainfrom
compiler-cli#64732JeanMeche wants to merge 2 commits intoangular:mainfrom
Conversation
angular-robot
bot
added
the
area: compiler
JeanMeche
force-pushed
the
compiler-cli-deep-imports
branch
9 times, most recently
from
4ee86cd to
d9afbc3
Compare
devversion
approved these changes
Oct 29, 2025
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
Nice! definitely time at some point to restrict visibility I think + maybe adjust the tsconfig path mappings so that IDEs don't generate such imports
JeanMeche
force-pushed
the
compiler-cli-deep-imports
branch
from
d9afbc3 to
bf11f86
Compare
angular-robot
bot
added
the
area: build & ci
alan-agius4
approved these changes
Oct 29, 2025
Contributor
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, as @devversion we should restrict visibility via bazel as otherwise it easy to regress.
JeanMeche
force-pushed
the
compiler-cli-deep-imports
branch
from
fa705ba to
2ee934a
Compare
Member
Author
|
The second commit includes the visibility restrictions ! |
JeanMeche
force-pushed
the
compiler-cli-deep-imports
branch
from
2ee934a to
5eca147
Compare
JeanMeche
force-pushed
the
compiler-cli-deep-imports
branch
from
5eca147 to
a0e81e2
Compare
JeanMeche
added
the
merge: caretaker note
Member
Author
|
caretaker note: CL to submit with this PR cl/825751016 |
devversion
approved these changes
Oct 30, 2025
JeanMeche
added
action: merge
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 6, 2025
Accessed symbols are grouped into dedicated `private` entries PR Close #64732
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 6, 2025
This should solve future deep imports issues. PR Close #64732
Contributor
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 6, 2025
This should solve future deep imports issues. PR Close #64732
Contributor
|
This PR breaks G3 due to an incomplete patch CL. See https://fusion2.corp.google.com/presubmit/829052597/OCL:829052597:BASE:829070786:1762462343436:3bf5630;groups=PossiblyNewlyFailing/targets for more details. |
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
Nov 6, 2025
…i` (angular#64732)" This reverts commit 05938c1.
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
Nov 6, 2025
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
Nov 6, 2025
…i` (angular#64732)" This reverts commit af16b48.
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
Nov 6, 2025
thePunderWoman
added a commit
that referenced
this pull request
Nov 6, 2025
This reverts commit 70d8ed4.
thePunderWoman
added a commit
that referenced
this pull request
Nov 6, 2025
This reverts commit acaa1e6.
thePunderWoman
added
action: cleanup
JeanMeche
force-pushed
the
compiler-cli-deep-imports
branch
from
a0e81e2 to
9a14c12
Compare
JeanMeche
force-pushed
the
compiler-cli-deep-imports
branch
from
9a14c12 to
78b84b1
Compare
Accessed symbols are grouped into dedicated `private` entries
JeanMeche
force-pushed
the
compiler-cli-deep-imports
branch
from
78b84b1 to
d6dfb59
Compare
JeanMeche
force-pushed
the
compiler-cli-deep-imports
branch
from
d6dfb59 to
3d532d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessed symbols are grouped into dedicated
privateentries