Repository navigation
refactor(router): signal-based RouterLinkActive - #62974
quentinderoubaix wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
846074f to
8a62ae8
Compare
|
Hi, thank you for your contribution. The way inputs are accessed & writen to in exisiting app makes migrating to signal inputs a complex task. We cannot allow ourselves to break existing apps/tests without a proper migration strategy. Also, having looked beyond that, this implementation broke several unit tests. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #62973
What is the new behavior?
A draft PR to discuss RouterLinkActive flicker.
Does this PR introduce a breaking change?
Not sure.
Other information
See issue