Skip to content

refactor(router): signal-based RouterLinkActive - #62974

Closed
quentinderoubaix wants to merge 1 commit into
angular:mainfrom
quentinderoubaix:proposal-routerlinkactive
Closed

quentinderoubaix wants to merge 1 commit into
angular:mainfrom
quentinderoubaix:proposal-routerlinkactive

Conversation

@quentinderoubaix

@quentinderoubaix quentinderoubaix commented Aug 3, 2025 •

Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #62973

What is the new behavior?

A draft PR to discuss RouterLinkActive flicker.

Does this PR introduce a breaking change?

Not sure.

  • Yes
  • No

Other information

See issue

@google-cla

google-cla Bot commented Aug 3, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: router labels Aug 3, 2025
@ngbot ngbot Bot added this to the Backlog milestone Aug 3, 2025
@quentinderoubaix quentinderoubaix changed the title feat(router): signal-based RouterLinkActive refactor(router): signal-based RouterLinkActive Aug 3, 2025
@quentinderoubaix
quentinderoubaix force-pushed the proposal-routerlinkactive branch from 846074f to 8a62ae8 Compare August 3, 2025 21:21
@JeanMeche

JeanMeche commented Aug 3, 2025 •

Copy link
Copy Markdown
Member

Hi, thank you for your contribution.
I'm sorry but this is unfortunately too much of a breaking change.

The way inputs are accessed & writen to in exisiting app makes migrating to signal inputs a complex task. We cannot allow ourselves to break existing apps/tests without a proper migration strategy.

Also, having looked beyond that, this implementation broke several unit tests.

@JeanMeche JeanMeche closed this Aug 3, 2025
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: router detected: feature PR contains a feature commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants