Repository navigation
Conversation
angular-robot
Bot
added
the
area: service-worker
In this commit, we mark the `SwPush` and `SwUpdate` classes as root providers. As a result, they are no longer statically referenced in the `provideServiceWorker` providers list, which previously forced them to be explicitly bundled into the main file. These classes might never be used—some consumers may use the service worker only for prefetching and caching assets. Currently, some users work around this by using `patch-package` to modify the service worker code and remove these classes from the providers list.
arturovt
force-pushed
the
fix/service-worker-providers
branch
from
July 29, 2025 19:34
440a90d to
028ccaa
Compare
Member
|
With #63364 we've announced that the service-worker package in now in maintenance mode and will not receive feature PRs and feature requests. The message is also visible here: https://angular.dev/ecosystem/service-workers |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we mark the
SwPushandSwUpdateclasses as root providers. As a result, they are no longer statically referenced in theprovideServiceWorkerproviders list, which previously forced them to be explicitly bundled into the main file. These classes might never be used—some consumers may use the service worker only for prefetching and caching assets.Currently, some users work around this by using
patch-packageto modify the service worker code and remove these classes from the providers list.