fix(platform-browser): Use the right namespace for mathML.#55622
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
fix(platform-browser): Use the right namespace for mathML.#55622JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
JeanMeche
added
action: review
Closed
JeanMeche
force-pushed
the
fix/math-ml-ns
branch
2 times, most recently
from
fbde29d to
8f353d8
Compare
|
Drive by LGTM. I'd just came to the same conclusion after some tangentially related debugging. |
JoostK
approved these changes
May 2, 2024
JoostK
added
target: patch
AndrewKushnir
approved these changes
May 2, 2024
AndrewKushnir
added
action: presubmit
Prior to this change, MathML element were created with the wrong namespace resulting in regular DOM `Element`. This commit fixes this. Related to angular#55608 (but doesn't fix it entirely).
Contributor
AndrewKushnir
added
action: merge
Contributor
|
This PR was merged into the repository by commit e533110. |
AndrewKushnir
pushed a commit
that referenced
this pull request
May 3, 2024
Member
|
@JeanMeche Since #55645 went into 17.3, could you backport this one as well? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, MathML element were created with the wrong namespace resulting in regular DOM
Element.This commit fixes this.
Related to #55608 (but doesn't fix it entirely).