Skip to content

chore(build): fix flakiness of the element probe global test #5493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marclaval wants to merge 1 commit into from
Closed

chore(build): fix flakiness of the element probe global test #5493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/angular2/src/facade/lang.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ export function setValueOnPath(global: any, path: string, value: any) {
var obj: any = global;
while (parts.length > 1) {
var name = parts.shift();
if (obj.hasOwnProperty(name)) {
if (obj.hasOwnProperty(name) && isPresent(obj[name])) {
obj = obj[name];
} else {
obj = obj[name] = {};
Expand Down
2 changes: 1 addition & 1 deletion modules/angular2/src/platform/browser/tools/tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ export function enableDebugTools(ref: ComponentRef): void {
* Disables Angular 2 tools.
*/
export function disableDebugTools(): void {
context.ng = undefined;
delete context.ng;
}
2 changes: 1 addition & 1 deletion modules/angular2/src/platform/dom/debug/debug_element_view_listener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,4 @@ export const ELEMENT_PROBE_PROVIDERS: any[] = CONST_EXPR([
CONST_EXPR(new Provider(AppViewListener, {useExisting: DebugElementViewListener})),
]);

export const ELEMENT_PROBE_BINDINGS = ELEMENT_PROBE_PROVIDERS;
export const ELEMENT_PROBE_BINDINGS = ELEMENT_PROBE_PROVIDERS;
2 changes: 1 addition & 1 deletion modules/angular2/test/platform/browser/debug/debug_element_view_listener_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export function main() {

async.done();
});
}), 10000);
}), 1000);
}
});
}