Repository navigation
Conversation
marclaval
added
the
action: review
marclaval
force-pushed
the
fixProbeFlake
branch
from
November 26, 2015 21:49
13cb56f to
66aa892
Compare
This was referenced Nov 30, 2015
IgorMinar
added
pr_state: LGTM
action: merge
Contributor
|
Closed via fb16c39 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 bugs here:
ngpropertysetValueOnPath()fails if there is an undefined or null property existing in the path.It is used to set the
DebugElementgetter onwindow.ng.probe.With the 2 combined, the test
element probe should provide a global function to inspect elementsfails if it is executed after the tools' tests, which happens from time to time, hence the flake.