Repository navigation
Conversation
marclaval
added
the
action: review
Contributor
|
@jelbourn can you please rebase and merge? Marc is already offline and we need to see if this change helps with flakes on CI |
IgorMinar
added
pr_state: LGTM
action: merge
Contributor
Author
|
Rebase done, let's wait for CI |
jelbourn
removed
the
action: cleanup
Contributor
|
Closed via 4fa1809 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same story as in #4756 with these 2 new tests. If they are successful when run individually in Edge, they make the browser to disconnect when they are part of the campaign.