Skip to content

Roll back iframe support#54629

Closed
dgp1130 wants to merge 2 commits into
angular:mainfrom
dgp1130:iframe-rollback
Closed

Roll back iframe support#54629
dgp1130 wants to merge 2 commits into
angular:mainfrom
dgp1130:iframe-rollback

Conversation

@dgp1130

@dgp1130 dgp1130 commented Feb 27, 2024

Copy link
Copy Markdown
Contributor

This rolls back #53934 as it seems to be causing #53953 and we will likely need more time to investigate the issue to identify the proper fix.

@dgp1130 dgp1130 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: devtools labels Feb 27, 2024
@ngbot ngbot Bot modified the milestone: Backlog Feb 27, 2024
@dgp1130 dgp1130 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 27, 2024
@dylhunn

dylhunn commented Feb 27, 2024

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit dd9f9d7.

@dylhunn dylhunn closed this in 133319e Feb 27, 2024
dylhunn pushed a commit that referenced this pull request Feb 27, 2024
dylhunn pushed a commit that referenced this pull request Feb 27, 2024
dylhunn pushed a commit that referenced this pull request Feb 27, 2024
@dgp1130
dgp1130 deleted the iframe-rollback branch February 27, 2024 23:47
AleksanderBodurri added a commit to AleksanderBodurri/angular that referenced this pull request Mar 11, 2024
AleksanderBodurri added a commit to AleksanderBodurri/angular that referenced this pull request Mar 11, 2024
dylhunn pushed a commit that referenced this pull request Mar 26, 2024
…lar DevTools' browser code (#53934)" (#54629)" (#54805)

This reverts commit dd9f9d7.

PR Close #54805
dylhunn pushed a commit that referenced this pull request Mar 26, 2024
dylhunn pushed a commit that referenced this pull request Mar 26, 2024
…lar DevTools' browser code (#53934)" (#54629)" (#54805)

This reverts commit dd9f9d7.

PR Close #54805
dylhunn pushed a commit that referenced this pull request Mar 26, 2024
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: devtools target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants