fix(devtools): stop trying to detect angular after 10 tries#51369
Closed
stagefright5 wants to merge 1 commit into
Closed
fix(devtools): stop trying to detect angular after 10 tries#51369stagefright5 wants to merge 1 commit into
stagefright5 wants to merge 1 commit into
Conversation
Just because this extension exists, all the opened tabs would be continuously detect angular without an end. I think that is very irresponsible. Also, I have just randomly added `10` as the number of tries
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Member
|
Because of the changes in #53934 we won't need this change. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just because this extension exists, all the
opened tabs continuously try to detect angular
without an end. I think that is very irresponsible.
Also, I have just randomly added
10as the number of triesPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
As of now, the extension tries to detect angular without an end to it. This is an odd behaviour and will make each and every
tab of the browser run the script forever.
Issue Number: N/A
What is the new behavior?
We try to detect angular for a maximum of 10 times and stop it.
Does this PR introduce a breaking change?
Other information