Skip to content

fix(docs-infra): replace use of turbo on StackBlitz with npm#50576

Closed
Nemikolh wants to merge 1 commit into
angular:mainfrom
Nemikolh:turbo-deprecated
Closed

fix(docs-infra): replace use of turbo on StackBlitz with npm#50576
Nemikolh wants to merge 1 commit into
angular:mainfrom
Nemikolh:turbo-deprecated

Conversation

@Nemikolh

@Nemikolh Nemikolh commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

turbo is being deprecated (EOL planned for Q1 2024) and can be replaced by npm with some tweaks. In particular, the installation step needs --legacy-peer-deps to mimic turbo's behaviour.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Explicit use of turbo on stackblitz.

What is the new behavior?

Use npm in place of turbo on StackBlitz.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

In the coming weeks using npm on StackBlitz will actually use the real npm instead of a shim on top of turbo. 🎉

Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour.
@github-actions

github-actions Bot commented Jun 5, 2023

Copy link
Copy Markdown

Deployed aio for 39c62fe to: https://ng-dev-previews-fw--pr-angular-angular-50576-l7yk6u8r.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@devversion devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Caretaker note: I will manually merge this into all active release branches starting with v13

@devversion devversion added action: merge The PR is ready for merge by the caretaker area: docs-infra merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jun 6, 2023
@ngbot ngbot Bot added this to the Backlog milestone Jun 6, 2023
@devversion devversion removed the request for review from josephperrott June 6, 2023 12:12
@pullapprove pullapprove Bot requested a review from josephperrott June 6, 2023 12:12

@devversion devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-dev-infra-approvers

@devversion devversion removed the request for review from josephperrott June 6, 2023 12:12
@devversion devversion added the target: patch This PR is targeted for the next patch release label Jun 6, 2023
@devversion

Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 34989fd.

devversion pushed a commit that referenced this pull request Jun 6, 2023
Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour.

PR Close #50576
@devversion devversion closed this in 34989fd Jun 6, 2023
devversion pushed a commit that referenced this pull request Jun 6, 2023
Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour.

PR Close #50576
devversion pushed a commit that referenced this pull request Jun 6, 2023
Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour.

PR Close #50576
devversion pushed a commit that referenced this pull request Jun 6, 2023
Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour.

PR Close #50576
@Nemikolh Nemikolh deleted the turbo-deprecated branch June 6, 2023 12:40
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 7, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…#50576)

Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour.

PR Close angular#50576
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants