fix(docs-infra): replace use of turbo on StackBlitz with npm #50576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour.
|
Deployed aio for 39c62fe to: https://ng-dev-previews-fw--pr-angular-angular-50576-l7yk6u8r.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
devversion
approved these changes
Jun 6, 2023
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM. Thanks.
Caretaker note: I will manually merge this into all active release branches starting with v13
devversion
added
action: merge
devversion
approved these changes
Jun 6, 2023
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: global-dev-infra-approvers
Member
|
This PR was merged into the repository by commit 34989fd. |
devversion
pushed a commit
that referenced
this pull request
Jun 6, 2023
Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour. PR Close #50576
devversion
pushed a commit
that referenced
this pull request
Jun 6, 2023
Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour. PR Close #50576
devversion
pushed a commit
that referenced
this pull request
Jun 6, 2023
Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour. PR Close #50576
devversion
pushed a commit
that referenced
this pull request
Jun 6, 2023
Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour. PR Close #50576
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…#50576) Turbo is being deprecated and can be replaced by npm with some tweaks. In particular, the installation step needs `--legacy-peer-deps` to mimic turbo's behaviour. PR Close angular#50576
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turbois being deprecated (EOL planned for Q1 2024) and can be replaced bynpmwith some tweaks. In particular, the installation step needs--legacy-peer-depsto mimicturbo's behaviour.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Explicit use of
turboon stackblitz.What is the new behavior?
Use
npmin place ofturboon StackBlitz.Does this PR introduce a breaking change?
Other information
In the coming weeks using
npmon StackBlitz will actually use the realnpminstead of a shim on top ofturbo. 🎉