Skip to content

docs: Fix punctuation for better consistency #50560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DinithiDiaz wants to merge 1 commit into from
Closed

docs: Fix punctuation for better consistency #50560

DinithiDiaz wants to merge 1 commit into from

Conversation

@DinithiDiaz
Copy link
Contributor

@DinithiDiaz DinithiDiaz commented Jun 3, 2023 •
edited
Loading

This is to fix a punctuation issue on the "Tour of Heroes - Introduction" page for better consistency.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The bullet list under the This Tour of Heroes tutorial provides an introduction to the fundamentals of Angular and shows you how to: section has an inconsistency in punctuation.

Page to be modified: https://angular.io/tutorial/tour-of-heroes

What is the new behavior?

The punctuation inconsistency issue in the bullet list under the line This Tour of Heroes tutorial provides an introduction to the fundamentals of Angular and shows you how to: has been fixed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@DinithiDiaz
docs: Fix punctuation for better consistency
93b36b9 
This is to fix a punctuation issue on the "Tour of Heroes - Introduction" page for better consistency.
@google-cla
Copy link

google-cla bot commented Jun 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from jessicajaniuk June 3, 2023 01:02
@ngbot ngbot bot added this to the Backlog milestone Jun 3, 2023
@JeanMeche
Copy link
Member

JeanMeche commented Jun 3, 2023

Hi, for your PR to move forward, could you sign the Google CLA ? Thx !

@DinithiDiaz
Copy link
Contributor Author

DinithiDiaz commented Jun 3, 2023

Hi, for your PR to move forward, could you sign the Google CLA ? Thx !

Hi @JeanMeche, I signed the certificate.
Thanks!

jessicajaniuk
jessicajaniuk approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 5, 2023
@alxhub
Copy link
Member

alxhub commented Jun 6, 2023

This PR was merged into the repository by commit a01ecf3.

@alxhub alxhub closed this in a01ecf3 Jun 6, 2023
alxhub pushed a commit that referenced this pull request Jun 6, 2023
@DinithiDiaz @alxhub
docs: Fix punctuation for better consistency (#50560)
5cfb6ca 
This is to fix a punctuation issue on the "Tour of Heroes - Introduction" page for better consistency.
PR Close #50560
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 7, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 7, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@DinithiDiaz @ChellappanRajan
docs: Fix punctuation for better consistency (angular#50560)
72bd2e4 
This is to fix a punctuation issue on the "Tour of Heroes - Introduction" page for better consistency.
PR Close angular#50560
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@DinithiDiaz @JeanMeche @alxhub @jessicajaniuk