fix(migrations): Prevent a component from importing itself. #50554

JeanMeche · 2023-06-02T13:43:09Z

This commit fixes the migrations for recursive components.

Before this fix, the migration was creating a forwardRef to the Component itself.

fixes #50525

PR Type

What kind of change does this PR introduce?

Bugfix

Does this PR introduce a breaking change?

No

JeanMeche · 2023-06-02T13:51:14Z

@crisbeto Can you take a look at the condition I added ? Is there a cleaner way to write it ?

crisbeto · 2023-06-02T14:05:26Z

packages/core/schematics/ng-generate/standalone-migration/to-standalone.ts

The proper place to fix this would be in the emit method inside packages/compiler-cli/src/ngtsc/typecheck/src/checker.ts where we determine if some is a forward reference or not.

Yes that works, let know what you think of the change 👍

packages/compiler-cli/src/ngtsc/typecheck/src/checker.ts

This commit fixes the migrations for recursive components. fixes angular#50525

JoostK

My approval is unlikely to be sufficient, but LGTM

crisbeto

LGTM

JoostK · 2023-06-03T09:20:36Z

packages/compiler-cli/src/ngtsc/typecheck/src/checker.ts

+      if (emitted.node === inContext.name) {
+        // Suppress self-imports since components do not have to import themselves.
+        return null;
+      }


I came to realise overnight that we don't need to go through the emitter to arrive at this conclusion. We should be able to do

if (refTo.node === inContext) { // Suppress self-imports since components do not have to import themselves. return null; }

as first statement of the emit method, instead of inspecting the emit result.

Yes, that works 👍

dylhunn · 2023-06-10T00:55:34Z

caretaker: windows target is a flake

pkozlowski-opensource · 2023-06-14T13:44:38Z

This PR was merged into the repository by commit 8468df1.

This commit fixes the migrations for recursive components. fixes #50525 PR Close #50554

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fanimations/16.0.4/16.1.1) | | [@angular/common](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcommon/16.0.4/16.1.1) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/16.0.4/16.1.1) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/16.0.4/16.1.1) | | [@angular/core](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcore/16.0.4/16.1.1) | | [@angular/forms](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fforms/16.0.4/16.1.1) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/16.0.4/16.1.1) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/16.0.4/16.1.1) | | [zone.js](https://github.com/angular/angular) ([changelog](https://github.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md)) | dependencies | patch | [`0.13.0` -> `0.13.1`](https://renovatebot.com/diffs/npm/zone.js/0.13.0/0.13.1) | --- ### Release Notes <details> <summary>angular/angular (@angular/animations)</summary> ### [`v16.1.1`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1611-2023-06-14) [Compare Source](angular/angular@16.1.0...16.1.1) ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [71360b3a3e](angular/angular@71360b3) | fix | libraries compiled with v16.1+ breaking with Angular framework v16.0.x ([#50715](angular/angular#50715)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [d9bed48eb5](angular/angular@d9bed48) | fix | extend toSignal to accept any Subscribable ([#50162](angular/angular#50162)) | ##### migrations | Commit | Type | Description | | -- | -- | -- | | [5e1d8444ae](angular/angular@5e1d844) | fix | Prevent a component from importing itself. ([#50554](angular/angular#50554)) |  ### [`v16.1.0`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1610-2023-06-13) [Compare Source](angular/angular@16.0.6...16.1.0) ##### compiler | Commit | Type | Description | | -- | -- | -- | | [4e663297c5](angular/angular@4e66329) | fix | error when reading compiled input transforms metadata in JIT mode ([#50600](angular/angular#50600)) | | [721bc72649](angular/angular@721bc72) | fix | resolve deprecation warning with TypeScript 5.1 ([#50460](angular/angular#50460)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [68017d4e75](angular/angular@68017d4) | feat | add ability to transform input values ([#50420](angular/angular#50420)) | | [69dadd2502](angular/angular@69dadd2) | feat | support TypeScript 5.1 ([#50156](angular/angular#50156)) | | [c0ebe34cbd](angular/angular@c0ebe34) | fix | add additional component metadata to component ID generation ([#50336](angular/angular#50336)) | ##### http | Commit | Type | Description | | -- | -- | -- | | [85c5427582](angular/angular@85c5427) | feat | Introduction of the `fetch` Backend for the `HttpClient` ([#50247](angular/angular#50247)) |  ### [`v16.0.6`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1606-2023-06-13) [Compare Source](angular/angular@16.0.5...16.0.6) ##### core | Commit | Type | Description | | -- | -- | -- | | [05ac0868c9](angular/angular@05ac086) | fix | avoid duplicated content during hydration while processing a component with i18n ([#50644](angular/angular#50644)) |  ### [`v16.0.5`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1605-2023-06-08) [Compare Source](angular/angular@16.0.4...16.0.5) ##### compiler | Commit | Type | Description | | -- | -- | -- | | [703b8fcac1](angular/angular@703b8fc) | fix | do not remove comments in component styles ([#50346](angular/angular#50346)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [2b6da93e19](angular/angular@2b6da93) | fix | incorrectly throwing error for self-referencing component ([#50559](angular/angular#50559)) | | [c992109d6c](angular/angular@c992109) | fix | wait for HTTP in `ngOnInit` correctly before server render ([#50573](angular/angular#50573)) | ##### platform-server | Commit | Type | Description | | -- | -- | -- | | [c0d4086c6e](angular/angular@c0d4086) | fix | surface errors during rendering ([#50587](angular/angular#50587)) |  </details> <details> <summary>angular/angular (zone.js)</summary> ### [`v0.13.1`](https://github.com/angular/angular/blob/HEAD/packages/zone.js/CHANGELOG.md#v0131-httpsgithubcomangularangularcomparezonejs-0130zonejs-v0131-2023-06-09) [Compare Source](angular/angular@zone.js-0.13.0...zone.js-0.13.1) ##### Bug Fixes - **zone.js:** enable monkey patching of the `queueMicrotask()` API in node.js ([#50467](angular/angular#50467)) ([381cb98](angular/angular@381cb98)) - **zone.js:** enable monkey patching of the `queueMicrotask()` API in node.js ([#50530](angular/angular#50530)) ([7837f71](angular/angular@7837f71)) - **zone.js:** patch entire promise in node ([#50552](angular/angular#50552)) ([cb31dbc](angular/angular@cb31dbc)), closes [#50513](angular/angular#50513) [#50457](angular/angular#50457) [#50414](angular/angular#50414) [#49930](angular/angular#49930) - **zone.js:** revert Mocha it.skip, describe.skip method patch ([#49329](angular/angular#49329)) ([5a2b622](angular/angular@5a2b622)) ##### Features - **zone.js:** jest 29 should ignore uncaught error console log ([#49325](angular/angular#49325)) ([bc412fd](angular/angular@bc412fd)), closes [#49110](angular/angular#49110) ##### Reverts - Revert "fix(zone.js): enable monkey patching of the `queueMicrotask()` API in node.js ([#50467](angular/angular#50467))" ([#50529](angular/angular#50529)) ([7567348](angular/angular@7567348)), closes [#50467](angular/angular#50467) [#50529](angular/angular#50529) [#50529](angular/angular#50529) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1927 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2023-08-12T00:08:07Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…50554) This commit fixes the migrations for recursive components. fixes angular#50525 PR Close angular#50554

JeanMeche marked this pull request as ready for review June 2, 2023 13:55

pullapprove bot requested a review from alxhub June 2, 2023 13:55

JeanMeche mentioned this pull request Jun 2, 2023

Bug (or Docs Bug?): Unable to test recursive standalone component due to NG0300 #50525

Closed

crisbeto reviewed Jun 2, 2023

View reviewed changes

JeanMeche force-pushed the fix/migration branch from be25dc4 to b7abc85 Compare June 2, 2023 14:22

JeanMeche mentioned this pull request Jun 2, 2023

fix(core): Discard self-imports on standalone components. #50557

Closed

2 tasks

JoostK reviewed Jun 2, 2023

View reviewed changes

packages/compiler-cli/src/ngtsc/typecheck/src/checker.ts Outdated Show resolved Hide resolved

fix(migrations): Prevent a component from importing itself.

b095258

This commit fixes the migrations for recursive components. fixes angular#50525

JeanMeche force-pushed the fix/migration branch from b7abc85 to b095258 Compare June 2, 2023 21:19

JeanMeche added action: review The PR is still awaiting reviews from at least one requested reviewer area: migrations Issues related to `ng update`/`ng generate` migrations labels Jun 2, 2023

ngbot bot added this to the Backlog milestone Jun 2, 2023

JeanMeche added the target: patch This PR is targeted for the next patch release label Jun 2, 2023

JoostK approved these changes Jun 2, 2023

View reviewed changes

crisbeto approved these changes Jun 2, 2023

View reviewed changes

crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 2, 2023

crisbeto removed the request for review from alxhub June 2, 2023 21:42

JoostK reviewed Jun 3, 2023

View reviewed changes

fixup! fix(migrations): Prevent a component from importing itself.

5a19bb1

angular-robot bot requested a review from crisbeto June 3, 2023 11:12

dylhunn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 10, 2023

crisbeto approved these changes Jun 14, 2023

View reviewed changes

pkozlowski-opensource closed this in 8468df1 Jun 14, 2023

pkozlowski-opensource pushed a commit that referenced this pull request Jun 14, 2023

fix(migrations): Prevent a component from importing itself. (#50554)

5e1d844

This commit fixes the migrations for recursive components. fixes #50525 PR Close #50554

JeanMeche deleted the fix/migration branch July 12, 2023 08:08

angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(migrations): Prevent a component from importing itself. #50554

fix(migrations): Prevent a component from importing itself. #50554

Uh oh!

JeanMeche commented Jun 2, 2023

Uh oh!

JeanMeche commented Jun 2, 2023

Uh oh!

crisbeto Jun 2, 2023

Uh oh!

JeanMeche Jun 2, 2023

Uh oh!

Uh oh!

JoostK left a comment

Uh oh!

crisbeto left a comment

Uh oh!

JoostK Jun 3, 2023

Uh oh!

JeanMeche Jun 3, 2023

Uh oh!

dylhunn commented Jun 10, 2023

Uh oh!

pkozlowski-opensource commented Jun 14, 2023

Uh oh!

angular-automatic-lock-bot bot commented Aug 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix(migrations): Prevent a component from importing itself. #50554

fix(migrations): Prevent a component from importing itself. #50554

Uh oh!

Conversation

JeanMeche commented Jun 2, 2023

PR Type

Does this PR introduce a breaking change?

Uh oh!

JeanMeche commented Jun 2, 2023

Uh oh!

crisbeto Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

JeanMeche Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoostK left a comment

Choose a reason for hiding this comment

Uh oh!

crisbeto left a comment

Choose a reason for hiding this comment

Uh oh!

JoostK Jun 3, 2023

Choose a reason for hiding this comment

Uh oh!

JeanMeche Jun 3, 2023

Choose a reason for hiding this comment

Uh oh!

dylhunn commented Jun 10, 2023

Uh oh!

pkozlowski-opensource commented Jun 14, 2023

Uh oh!

angular-automatic-lock-bot bot commented Aug 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants