Skip to content

Conversation

@cadedupont
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #50488
Tab size differs in code snippet from 2 to 4, modified to make indentation size 4 for entire snippet.

What is the new behavior?

Code indentation is more evenly distributed in lifecycle guide documentation

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented May 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from crisbeto May 26, 2023 21:21
Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see CONTRIBUTING.md for some instructions on how the PR can be updated.

Comment on lines 111 to 112
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to make the opposite change: replace the tabs in the lines below with 2 spaces each.

@JoostK JoostK added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: docs target: patch This PR is targeted for the next patch release labels May 27, 2023
@ngbot ngbot bot modified the milestone: Backlog May 27, 2023
@ngbot ngbot bot removed this from the Backlog milestone May 27, 2023
@cadedupont cadedupont requested a review from JoostK May 27, 2023 18:21
@JoostK
Copy link
Member

JoostK commented May 27, 2023

The changes now look good, but you'll need to combine the two commits into one and rephrase the commit message to align with the convention.

You can either run an interactive rebase to reword the first commit and fixup the second commit, or perform a soft reset to before the commits were made and then create a commit from scratch. The latter is probably easiest, although learning how to do rebases could be beneficial in the long run 😃

Using a soft reset looks something like this:

git reset --soft HEAD~2
git commit -am 'docs: fix indentation issue in component lifecycle'
git push --force-with-lease

@ngbot ngbot bot added this to the Backlog milestone May 28, 2023
@cadedupont
Copy link
Contributor Author

3rd time's the charm hopefully haha, apologies but thank you for the guidance! :)

Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JoostK JoostK added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 28, 2023
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 7, 2023
@alxhub
Copy link
Member

alxhub commented Jun 7, 2023

This PR was merged into the repository by commit ab35596.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 8, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants