-
Notifications
You must be signed in to change notification settings - Fork 27k
docs: fix indentation issue in component lifecycle #50490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
JoostK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see CONTRIBUTING.md for some instructions on how the PR can be updated.
aio/content/guide/lifecycle-hooks.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to make the opposite change: replace the tabs in the lines below with 2 spaces each.
|
The changes now look good, but you'll need to combine the two commits into one and rephrase the commit message to align with the convention. You can either run an interactive rebase to Using a soft reset looks something like this: git reset --soft HEAD~2
git commit -am 'docs: fix indentation issue in component lifecycle'
git push --force-with-lease |
|
3rd time's the charm hopefully haha, apologies but thank you for the guidance! :) |
JoostK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
crisbeto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This PR was merged into the repository by commit ab35596. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #50488
Tab size differs in code snippet from 2 to 4, modified to make indentation size 4 for entire snippet.
What is the new behavior?
Code indentation is more evenly distributed in lifecycle guide documentation
Does this PR introduce a breaking change?
Other information