Bypass unnecessary top level actions in local compilation mode #50486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In local mode compilation the TS semantic check issues tons of diagnostics due to the fact that the file dependencies (.d.ts files) are not available in the program. So it needs to be disabled. This commit should not cause any issue for the exsiting projects as it just removes a diagnostic in the local compilation mode.
…lation mode. In local mode we don't make use of .d.ts files for Angular compilation, so their transformation can be ditched.
devversion
approved these changes
May 31, 2023
dylhunn
added
the
area: compiler
Member
|
Caretaker note: Unrelated internal test failure. All other targets pass |
devversion
added
action: merge
This comment was marked as outdated.
This comment was marked as outdated.
devversion
added
the
merge: caretaker note
Member
|
This PR was merged into the repository by commit 9648fc4. |
alxhub
pushed a commit
that referenced
this pull request
Jun 7, 2023
…ion (#50486) In local mode compilation the TS semantic check issues tons of diagnostics due to the fact that the file dependencies (.d.ts files) are not available in the program. So it needs to be disabled. This commit should not cause any issue for the exsiting projects as it just removes a diagnostic in the local compilation mode. PR Close #50486
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ion (angular#50486) In local mode compilation the TS semantic check issues tons of diagnostics due to the fact that the file dependencies (.d.ts files) are not available in the program. So it needs to be disabled. This commit should not cause any issue for the exsiting projects as it just removes a diagnostic in the local compilation mode. PR Close angular#50486
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…lation mode. (angular#50486) In local mode we don't make use of .d.ts files for Angular compilation, so their transformation can be ditched. PR Close angular#50486
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
In local compilation mode we no longer do the TS semantic check and transforming .d.ts files.
Does this PR introduce a breaking change?
Other information