Skip to content

[16.0.x] Revert "fix(core): add additional component metadata to component ID generation (#50203)" #50335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AndrewKushnir wants to merge 2 commits into from
Closed

[16.0.x] Revert "fix(core): add additional component metadata to component ID generation (#50203)" #50335

AndrewKushnir wants to merge 2 commits into from

Conversation

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented May 16, 2023

This reverts commit 52c74d3.

The reason for revert: this change is breaking some targets in g3.

@AndrewKushnir
Revert "refactor(core): avoid using def.signal during component id …
cd886f4 
…computation (angular#50238)"

This reverts commit c9657bd.

The reason for revert: this change is breaking some targets in g3.
@AndrewKushnir
Revert "fix(core): add additional component metadata to component ID …
5654b15 
…generation (angular#50203)"

This reverts commit 52c74d3.

The reason for revert: this change is breaking some targets in g3.
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release PullApprove: disable labels May 16, 2023
@ngbot ngbot bot modified the milestone: Backlog May 16, 2023
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented May 16, 2023

This PR was merged into the repository by commit 3eafb4b.

AndrewKushnir added a commit that referenced this pull request May 16, 2023
@AndrewKushnir
Revert "refactor(core): avoid using def.signal during component id …
4c5c054 
…computation (#50238)" (#50335)

This reverts commit c9657bd.

The reason for revert: this change is breaking some targets in g3.

PR Close #50335
AndrewKushnir added a commit that referenced this pull request May 16, 2023
@AndrewKushnir
Revert "fix(core): add additional component metadata to component ID …
3eafb4b 
…generation (#50203)" (#50335)

This reverts commit 52c74d3.

The reason for revert: this change is breaking some targets in g3.

PR Close #50335
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 16, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

1 participant

@AndrewKushnir