refactor(core): avoid using def.signal during component id computation
#50238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the code in 16.0.x branch to avoid using the `def.signals` field on a component, while calculating component id. The `signal` field was introduced later and will be available in 16.1.0.
AndrewKushnir
added
action: merge
alan-agius4
approved these changes
May 10, 2023
AndrewKushnir
added
merge: caretaker note
Contributor
Author
|
This PR was merged into the repository by commit c9657bd. |
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
May 16, 2023
…computation (angular#50238)" This reverts commit c9657bd. The reason for revert: this change is breaking some targets in g3.
AndrewKushnir
added a commit
that referenced
this pull request
May 16, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the code in 16.0.x branch to avoid using the
def.signalsfield on a component, while calculating component id. Thesignalfield was introduced later and will be available in 16.1.0.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?