refactor(core): finalize rxjs-interop options & docs #50071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
AndrewKushnir,
dylhunn and
pkozlowski-opensource
alxhub
force-pushed
the
v16/to-observable
branch
from
5986ac6 to
6459d38
Compare
AndrewKushnir
approved these changes
Apr 28, 2023
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
dylhunn
approved these changes
Apr 28, 2023
Contributor
dylhunn
left a comment
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: fw-core, public-api
This commit introduces an interface for `toSignal` options to mirror that of `toObservable`, and adjusts docs for both symbols. It also adds the ability for `toSignal` to manually specify `DestroyRef` (similarly to `toObservable` accepting an injector) or for `toSignal` automatic cleanup to be disabled (in which case the subscription persists until the Observable completes). Either option allows `toSignal` to be used outside of a DI context, like `toObservable`.
alxhub
force-pushed
the
v16/to-observable
branch
from
6459d38 to
d9c058f
Compare
alxhub
added
target: rc
atscott
approved these changes
Apr 28, 2023
Contributor
atscott
left a comment
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Member
Author
|
This PR was merged into the repository by commit cc89766. |
alxhub
added a commit
that referenced
this pull request
Apr 28, 2023
This commit introduces an interface for `toSignal` options to mirror that of `toObservable`, and adjusts docs for both symbols. It also adds the ability for `toSignal` to manually specify `DestroyRef` (similarly to `toObservable` accepting an injector) or for `toSignal` automatic cleanup to be disabled (in which case the subscription persists until the Observable completes). Either option allows `toSignal` to be used outside of a DI context, like `toObservable`. PR Close #50071
sr5434
pushed a commit
to sr5434/angular
that referenced
this pull request
May 3, 2023
This commit introduces an interface for `toSignal` options to mirror that of `toObservable`, and adjusts docs for both symbols. It also adds the ability for `toSignal` to manually specify `DestroyRef` (similarly to `toObservable` accepting an injector) or for `toSignal` automatic cleanup to be disabled (in which case the subscription persists until the Observable completes). Either option allows `toSignal` to be used outside of a DI context, like `toObservable`. PR Close angular#50071
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces an interface for
toSignaloptions to mirror that oftoObservable, and adjusts docs for both symbols. It also adds the ability fortoSignalto manually specifyDestroyRef(similarly totoObservableaccepting an injector) or fortoSignalautomatic cleanup to be disabled (in which case the subscription persists until the Observable completes). Either option allowstoSignalto be used outside of a DI context, liketoObservable.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information