fix(platform-server): remove dependency on @angular/platform-browser-dynamic
#50064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: rc
alan-agius4
force-pushed
the
platform-server-dynamic-ssr
branch
from
0c84f78 to
95430bd
Compare
alan-agius4
added
the
action: review
AndrewKushnir
approved these changes
Apr 28, 2023
AndrewKushnir
approved these changes
Apr 28, 2023
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
@alxhub could you please also take a look at the change before the merge?
alan-agius4
force-pushed
the
platform-server-dynamic-ssr
branch
from
95430bd to
0136848
Compare
angular-robot
bot
added
the
detected: breaking change
…-dynamic` Using `@angular/platform-browser-dynamic` is no longer required for JIT scenarios with Ivy. Instead `@angular/compiler` should be imported instead. This change is part of the effort to reduce the server bundles sizes, which is needed to support cloud workers. BREAKING CHANGE: Users that are using SSR with JIT mode will now need to add `import to @angular/compiler` before bootstrapping the application. **NOTE:** this does not effect users using the Angular CLI.
alan-agius4
force-pushed
the
platform-server-dynamic-ssr
branch
from
0136848 to
82b51e9
Compare
jessicajaniuk
approved these changes
Apr 28, 2023
Contributor
jessicajaniuk
left a comment
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Author
|
Caretaker note: Presubmit was green prior to the commit message change. |
alan-agius4
added
the
merge: caretaker note
alxhub
approved these changes
Apr 28, 2023
alan-agius4
added
action: merge
Member
|
This PR was merged into the repository by commit 06452af. |
alxhub
pushed a commit
that referenced
this pull request
May 1, 2023
…-dynamic` (#50064) Using `@angular/platform-browser-dynamic` is no longer required for JIT scenarios with Ivy. Instead `@angular/compiler` should be imported instead. This change is part of the effort to reduce the server bundles sizes, which is needed to support cloud workers. BREAKING CHANGE: Users that are using SSR with JIT mode will now need to add `import to @angular/compiler` before bootstrapping the application. **NOTE:** this does not effect users using the Angular CLI. PR Close #50064
sr5434
pushed a commit
to sr5434/angular
that referenced
this pull request
May 3, 2023
…-dynamic` (angular#50064) Using `@angular/platform-browser-dynamic` is no longer required for JIT scenarios with Ivy. Instead `@angular/compiler` should be imported instead. This change is part of the effort to reduce the server bundles sizes, which is needed to support cloud workers. BREAKING CHANGE: Users that are using SSR with JIT mode will now need to add `import to @angular/compiler` before bootstrapping the application. **NOTE:** this does not effect users using the Angular CLI. PR Close angular#50064
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
@angular/platform-browser-dynamicis no longer required for JIT scenarios with Ivy. Instead@angular/compilershould be imported instead.This change is part of the effort to reduce the server bundles sizes, which is needed to support cloud workers.
BREAKING CHANGE:
Users that are using SSR with JIT mode will now need to add
import to @angular/compilerbefore bootstrapping the application.NOTE: this does not effect users using the Angular CLI.