fix(compiler-cli): catch fatal diagnostic when getting diagnostics fo… #50046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: language-service
alxhub
approved these changes
Apr 27, 2023
…r components This commit adds similar handling to what was done in angular@ed817e3. The language service calls the `getDiagnosticsForComponent` function when the file is not a typescript file. fixes angular/vscode-ng-language-service#1881
atscott
force-pushed
the
catchFatalDiagnosticsForComponent
branch
from
a43d90b to
a990bcc
Compare
Member
|
This PR was merged into the repository by commit ce00738. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Apr 28, 2023
…r components (#50046) This commit adds similar handling to what was done in ed817e3. The language service calls the `getDiagnosticsForComponent` function when the file is not a typescript file. fixes angular/vscode-ng-language-service#1881 PR Close #50046
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Apr 28, 2023
…r components (#50046) This commit adds similar handling to what was done in ed817e3. The language service calls the `getDiagnosticsForComponent` function when the file is not a typescript file. fixes angular/vscode-ng-language-service#1881 PR Close #50046
sr5434
pushed a commit
to sr5434/angular
that referenced
this pull request
May 3, 2023
…r components (angular#50046) This commit adds similar handling to what was done in angular@ed817e3. The language service calls the `getDiagnosticsForComponent` function when the file is not a typescript file. fixes angular/vscode-ng-language-service#1881 PR Close angular#50046
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r components
This commit adds similar handling to what was done in ed817e3. The language service calls the
getDiagnosticsForComponentfunction when the file is not a typescript file.fixes angular/vscode-ng-language-service#1881