refactor(compiler-cli): add back ngcc as a no-op with a warning #50045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leosvelperez
changed the title
pkozlowski-opensource
added
action: review
JoostK
reviewed
Apr 27, 2023
Member
JoostK
left a comment
JoostK
left a comment
There was a problem hiding this comment.
Thanks! Could you please change this to a refactor commit, as the current feat commit cannot be landed for 16.0-rc
dgp1130
reviewed
Apr 27, 2023
This commit adds back `ngcc` as a no-op operation. When invoked it will warn providing details about removing `ngcc`. In Angular 17, this will be removed.
leosvelperez
force-pushed
the
feature/ngcc-warning
branch
from
44a89f2 to
b3c1cda
Compare
leosvelperez
changed the title
JoostK
added
action: merge
Member
|
This shouldn't have any impact on g3, but let's run a presubmit regardless to know there's no sync conflicts. |
dgp1130
approved these changes
Apr 27, 2023
Contributor
dgp1130
left a comment
dgp1130
left a comment
There was a problem hiding this comment.
Message looks good to me, I agree we shouldn't add a dependency for terminal coloring just for this so your solution looks fine.
pkozlowski-opensource
added
merge: caretaker note
Member
|
caretaker note: none of the files in this PR impacts G3, no need to run presubmit |
Member
|
This PR was merged into the repository by commit cfab3ad. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Apr 28, 2023
This commit adds back `ngcc` as a no-op operation. When invoked it will warn providing details about removing `ngcc`. In Angular 17, this will be removed. PR Close #50045
sr5434
pushed a commit
to sr5434/angular
that referenced
this pull request
May 3, 2023
…lar#50045) This commit adds back `ngcc` as a no-op operation. When invoked it will warn providing details about removing `ngcc`. In Angular 17, this will be removed. PR Close angular#50045
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
The Angular Compatibility Compiler is removed in Angular 16 and therefore,
ngccis no longer available in users' workspaces. In some setups,ngccis invoked in thepostinstallscript of thepackage.json. When updating Angular, in scenarios wherepostinstallis run (e.g. Nx migrations), this throws an error before a migration can remove thengccinvocation. This makes the update process to be more complicated.What is the new behavior?
ngccis available as a no-op operation. When invoked, it will warn, providing details about removingngcc. It gives some context at the tool level to folks who haven't caught up with news thatngccwas removed.Note: In Angular 17, this will be removed.
Does this PR introduce a breaking change?
Other information
I chose to inline some slightly modified functionality from chalk for the colors in the console. I did that to avoid adding an extra dependency for this. I'm open to adding the dependency instead or implementing a different way to get colors in the console in a cross-platform way if preferred.