Skip to content

docs: Add first-app tutorial #49980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarkTechson wants to merge 26 commits into from
Closed

docs: Add first-app tutorial #49980

MarkTechson wants to merge 26 commits into from

Conversation

@MarkTechson
Copy link
Contributor

@MarkTechson MarkTechson commented Apr 24, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently the first app tutorial is incomplete.

Issue Number: N/A

What is the new behavior?

The first app tutorial is now complete

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Shout out to bob-watson for his work on this PR.

@google-cla
Copy link

google-cla bot commented Apr 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ngbot ngbot bot added this to the Backlog milestone Apr 24, 2023
@jessicajaniuk jessicajaniuk added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Apr 24, 2023
@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Apr 24, 2023

@MarkTechson Looks like this has a rebase issue with an extra merge commit at the end. If you need assistance with the lint and test failures, let me know.

@github-actions
Copy link

github-actions bot commented Apr 26, 2023 •
edited
Loading

Deployed aio for 95a19df to: https://ng-dev-previews-fw--pr-angular-angular-49980-9x2t0vhm.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@twerske
Copy link
Contributor

twerske commented Apr 26, 2023

Yay! It's happening!

I did an initial review of just the documentation structure before I review content:

  1. I think the navigation and page structure need to be updated? Currently the preview still shows Tour of Heroes - and the angular.io/start old content. Which one is this meant to replace? Currently it seems like an additional new tutorial?

Screenshot 2023-04-26 at 11 06 59 AM

  1. The titles of each step are quite long (ie. "Introduction to Angular tutorial - the First Angular app", "First Angular app lesson 1 - Hello world") - are these final?

  2. Are the videos meant to be embedded before this merges?

  3. The Before you start/After you finish get really repetitive and make the lessons look pretty daunting and long, is that needed for all 14 pages? Google's codelabs do this step once as an example: https://codelabs.developers.google.com/

alxhub pushed a commit that referenced this pull request May 1, 2023
@MarkTechson @alxhub
docs: update broken tests (#49980)
4f2e70d 
PR Close #49980
alxhub pushed a commit that referenced this pull request May 1, 2023
@MarkTechson @alxhub
docs: update the intro page (#49980)
952569c 
Update the introduction page to include a link to the new tutorial and to remove links to the other tutorials to give learners a clearer path forward. Also, add files to pull approve.

PR Close #49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@sr5434
docs: add first-app tutorial lesson-00 (angular#49980)
1d0a8ab 
PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@sr5434
docs: add first-app tutorial lesson-01 (angular#49980)
bc9fe70 
PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@sr5434
docs: add first-app tutorial lesson-02 (angular#49980)
e4dc271 
PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@sr5434
docs: add first-app tutorial lesson-04 (angular#49980)
92aad14 
PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@sr5434
docs: add first-app tutorial lesson-09 (angular#49980)
f7aec30 
PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@sr5434
docs: add first-app tutorial lesson-11 (angular#49980)
3a91f79 
PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@sr5434
docs: add first-app tutorial lesson-12 (angular#49980)
51d0dd0 
PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update first-app-tutorial introduction (angular#49980)
59ab76d 
Add application screenshot (and create the directory to host images for this tutorial). Also, update index.md instructions and complete TODOs/missing content.

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update first-app tutorial lesson-01 (angular#49980)
073d6aa 
Update the content to complete the instructions required for users to build the app as described in lesson one. Also, added a new image that represents that app as of completing lesson-01.

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update first-app lesson-02 (angular#49980)
5e78fe7 
Updates the learning content, the snippet regions from the code examples, and adds screenshots for the lesson. Also, add a base page for lesson-03

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: add first-app lesson tutorial-03 (angular#49980)
fff8c19 
Adds files for the 03 lesson and updated the 02 lesson in some places where the language was incorrect or unclear

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: add first-app lesson tutorial-04 (angular#49980)
b0a9cfb 
Update the tutorial for lesson 04 on interfaces. Also added images required for the base app. Created the placeholder for the next lesson so the app works if built from this branch. Updated navigation to include this step in the navigation menu.

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update first-app lesson 05 (angular#49980)
b61f872 
This commit does the following:
- Add the instructional content for lesson 05
- Add an entry to navigation.json for this lesson
- Adds doc regions to the housing-location.component file
- Adds a placeholder for lesson 06 (that way links work now)

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: sync assets and styles across lessons (angular#49980)
7763627 
Each individual lesson should have the images available in the download since a learner can start from any lesson. So, we're adding images here. Also, sync'ing styles for consistency across the lessons. This is fixing some previous commits that didn't include these changes. The goal is that for future commits we can have less changes and focused solely on that lesson

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: add first-app-lesson-06 (angular#49980)
1593bc5 
Adds lesson 06 as well as fixes up some code inconsistencies. Adds docregions to some lessons and adds a missed step, misspellings and more to previous lessons.

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: add first-app lesson 07 (angular#49980)
37bce84 
Adds the content for lesson 07, a new image, a navigation entry and some updates to the example code for this lesson. Also, this updates previous lessons where typos and copy/pasta errors show up

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: add first app tutorial lesson 08 (angular#49980)
3c5810f 
Adds lesson 8, some images, fixes a typo and adds the required navigation item

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update first-app tutorial lesson 09 (angular#49980)
3cad208 
Updates the content of the lesson and adds a placeholder for the next lesson. Also, updates the code for the example to reflect the patterns from the previous iterations.

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update first-app tutorial lesson 10 (angular#49980)
3fcb60c 
Updated the content for the tutorial lesson 10, added doc regions to the code and updated the service. Also added a placeholder for lesson 11.

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update first-app tutorial lesson 11 (angular#49980)
80fb7f8 
Add content for lesson 11. Update previous lessons and code examples be in line with the latest lesson formatting.

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update first-app lesson 12 (angular#49980)
d3a5529 
Add content for tutorial lesson 12 and update the code examples.

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update first-app tutorial lesson 13 (angular#49980)
a3cb4f8 
Adds the content for lesson 13, fixes some code inconsistencies for the services code in the examples, and adds this lesson to the navigation.

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: add first-app lesson-14 (angular#49980)
4823483 
Adds the content for lesson 14, updates a mistake in lesson 13, and updates the tutorial index page.

PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update linting issues and fix failing tests (angular#49980)
9e30f8d 
PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update broken tests (angular#49980)
2d867a4 
PR Close angular#49980
sr5434 pushed a commit to sr5434/angular that referenced this pull request May 3, 2023
@MarkTechson @sr5434
docs: update the intro page (angular#49980)
33943ef 
Update the introduction page to include a link to the new tutorial and to remove links to the other tutorials to give learners a clearer path forward. Also, add files to pull approve.

PR Close angular#49980
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 1, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

+1 more reviewer

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

v16-final

Development

Successfully merging this pull request may close these issues.

8 participants

@MarkTechson @jessicajaniuk @twerske @alxhub @josephperrott @mgechev @jelbourn @trekladyone