refactor(core): Synchronously emit the current signal value in toObservable#49894
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): Synchronously emit the current signal value in toObservable#49894atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
alxhub
approved these changes
Apr 17, 2023
alxhub
approved these changes
Apr 17, 2023
Contributor
Author
|
Adding blocked label since we have two possible options here that we should discuss as a team: |
JeanMeche
reviewed
Apr 17, 2023
alxhub
approved these changes
Apr 18, 2023
…rvable As described in angular#49681 (reply in thread), if an `Observable` created from a signal with `toObservable` is subscribed to in a template, it will initially have `null` as the value. Immediately after the template is done executing, effects are flushed and this results in the `AsyncPipe` getting a new value before the `checkNoChanges` pass, resulting in `ExpressionChanged` error. ``` template: '{{obs$ | async}}' ... obs$ = toObservable(signal(0)); ``` Instead, this commit updates the `toObservable` to synchronously emit the initial value to the Observable stream. Side note here: We don't exactly encourage this pattern. Instead of using `AsyncPipe`, the template should just read signals.
toObservable until next tick
Contributor
|
This PR was merged into the repository by commit 02a539c. |
dylhunn
pushed a commit
that referenced
this pull request
Apr 25, 2023
…rvable (#49894) As described in #49681 (reply in thread), if an `Observable` created from a signal with `toObservable` is subscribed to in a template, it will initially have `null` as the value. Immediately after the template is done executing, effects are flushed and this results in the `AsyncPipe` getting a new value before the `checkNoChanges` pass, resulting in `ExpressionChanged` error. ``` template: '{{obs$ | async}}' ... obs$ = toObservable(signal(0)); ``` Instead, this commit updates the `toObservable` to synchronously emit the initial value to the Observable stream. Side note here: We don't exactly encourage this pattern. Instead of using `AsyncPipe`, the template should just read signals. PR Close #49894
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in
#49681 (reply in thread), if an
Observablecreated from a signal withtoObservableis subscribed to in a template, it will initially havenullas the value. Immediately after the template is done executing, effects are flushed and this results in theAsyncPipegetting a new value before thecheckNoChangespass, resulting inExpressionChangederror.Instead, this commit updates the inner effect of
toObservableto not be created until the next microtask.