fix(core): allow async functions in effects#49783
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): allow async functions in effects#49783pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Conversation
pkozlowski-opensource
added
action: review
pkozlowski-opensource
force-pushed
the
signals_effect_cleanup
branch
from
89adc7c to
2782f3a
Compare
atscott
approved these changes
Apr 11, 2023
Contributor
atscott
left a comment
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: fw-core, public-api
jessicajaniuk
approved these changes
Apr 11, 2023
Contributor
jessicajaniuk
left a comment
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
This change makes is possible to use async functions (ones returning a promise) as effect run functions. To make it possible, the signature of the effect function changed: effect cleanup function is registered now (using a dedicated callback passed to the effect creation) instead of being returned from the effect function.
pkozlowski-opensource
force-pushed
the
signals_effect_cleanup
branch
from
2782f3a to
180615a
Compare
pkozlowski-opensource
added
action: merge
Member
Author
|
caretaker note: the G3 failures are pre-existing and unrelated |
Contributor
|
This PR was merged into the repository by commit ce38be0. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 11, 2023
This change makes is possible to use async functions (ones returning a promise) as effect run functions. To make it possible, the signature of the effect function changed: effect cleanup function is registered now (using a dedicated callback passed to the effect creation) instead of being returned from the effect function. PR Close #49783
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes is possible to use async functions (ones returning a promise) as effect run functions.
To make it possible, the signature of the effect function changed: effect cleanup function is registered now (using a dedicated callback passed to the effect creation) instead of being returned from the effect function.