fix(migrations): delete barrel exports in standalone migration #49176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
force-pushed
the
standalone-migration-barrels
branch
from
1966820 to
76e5da4
Compare
devversion
approved these changes
Feb 23, 2023
packages/core/schematics/ng-generate/standalone-migration/prune-modules.ts
Outdated
Show resolved
Hide resolved
Adds some logic to automatically delete `export * from './foo'` style imports. Previously they weren't being picked up, because finding all the references using the language service doesn't include barrel exports.
crisbeto
force-pushed
the
standalone-migration-barrels
branch
from
76e5da4 to
fe3cf99
Compare
crisbeto
added
action: merge
Contributor
|
This PR was merged into the repository by commit 7dd1957. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Feb 24, 2023
Adds some logic to automatically delete `export * from './foo'` style imports. Previously they weren't being picked up, because finding all the references using the language service doesn't include barrel exports. PR Close #49176
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some logic to automatically delete
export * from './foo'style imports. Previously they weren't being picked up, because finding all the references using the language service doesn't include barrel exports.