fix(zone.js): zone-node only patch Promise.prototype.then #49144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaLiPassion
force-pushed
the
test-zone-promise
branch
2 times, most recently
from
abf4418 to
d1fdd70
Compare
JiaLiPassion
force-pushed
the
test-zone-promise
branch
from
d1fdd70 to
129e17b
Compare
2 tasks
JiaLiPassion
force-pushed
the
test-zone-promise
branch
3 times, most recently
from
86957e4 to
4499b3b
Compare
alan-agius4
reviewed
Feb 21, 2023
alan-agius4
approved these changes
Feb 21, 2023
Contributor
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, confirmed that this solved the issue.
alan-agius4
added
the
action: cleanup
JiaLiPassion
force-pushed
the
test-zone-promise
branch
from
4499b3b to
3fe5b40
Compare
JiaLiPassion
requested review from
alxhub
and removed request for
josephperrott
alan-agius4
added
action: review
AndrewKushnir
approved these changes
Feb 21, 2023
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
@JiaLiPassion thanks for the fix 👍
I've left a couple minor comments and I also have a question (just to double check): would that version work correctly with the NodeJS version range that we have for Angular apps (starting from v15.2)?
(we can also update the feat(zone.js) -> fix(zone.js), so that we can land this change sooner than v16)
Close angular#47872 zone-node only patches `Promise.prototype.then` instead of patch `Promise` itself. So the new NodeJS `SafePromise` will not complain the Promise.prototype.then called on incompatible receiver. We should also do this change on browser zone.js patch, but it will be a big breaking change, because Promise.prototype.then will not work with `fakeAsync` any longer.
Contributor
Author
|
@AndrewKushnir, thank you for the review, I have updated the code and also the git comment for the commit. |
JiaLiPassion
force-pushed
the
test-zone-promise
branch
from
3fe5b40 to
6c7754c
Compare
AndrewKushnir
changed the title
AndrewKushnir
approved these changes
Feb 22, 2023
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback @JiaLiPassion 👍
AndrewKushnir
added
action: presubmit
Contributor
Contributor
|
Caretaker note: this CL contains an updated patch for g3. |
alan-agius4
added
the
action: review
alxhub
approved these changes
Feb 24, 2023
alan-agius4
added
action: merge
AndrewKushnir
added
target: minor
Contributor
|
This PR was merged into the repository by commit d1ac3aa. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #47872
zone-node only patches
Promise.prototype.theninstead of patchPromiseitself. So the new NodeJSSafePromisewill not complainthe Promise.prototype.then called on incompatible receiver.
We should also do this change on browser zone.js patch, but it will
be a big breaking change, because Promise.prototype.then will not work
with
fakeAsyncany longer.