Skip to content

docs: remove unused style guides. - #48587

Closed
JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:docs/remove-unused-styleguides
Closed

JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:docs/remove-unused-styleguides

Conversation

@JeanMeche

Copy link
Copy Markdown
Member

Some example projects weren't used anymore by the styleguide, let's remove them.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes

@ngbot ngbot Bot added this to the Backlog milestone Dec 24, 2022

@dylhunn dylhunn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question -- how did you determine conclusively that these are no longer used?

reviewed-for: public-api

@pullapprove
pullapprove Bot requested a review from jessicajaniuk December 27, 2022 18:40
@JeanMeche

JeanMeche commented Dec 27, 2022 •

Copy link
Copy Markdown
Member Author

LGTM with a question -- how did you determine conclusively that these are no longer used?

@dylhunn

They were not used in styleguide.md anymore nor did I found any reference in the project.

@jessicajaniuk jessicajaniuk left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: public-api

@pullapprove
pullapprove Bot requested a review from jessicajaniuk January 5, 2023 20:56
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 5, 2023
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Jan 10, 2023
@AndrewKushnir

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 518cc63.

AndrewKushnir pushed a commit that referenced this pull request Jan 11, 2023
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 11, 2023
@JeanMeche
JeanMeche deleted the docs/remove-unused-styleguides branch May 2, 2023 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants