Skip to content

docs: remove onInit from nav component - #48586

Closed
aanchal88 wants to merge 1 commit into
angular:mainfrom
aanchal88:docs/nav-oninit
Closed

docs: remove onInit from nav component#48586
aanchal88 wants to merge 1 commit into
angular:mainfrom
aanchal88:docs/nav-oninit

Conversation

@aanchal88

@aanchal88 aanchal88 commented Dec 24, 2022

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove
pullapprove Bot requested a review from jessicajaniuk December 24, 2022 07:05
@ngbot ngbot Bot added this to the Backlog milestone Dec 24, 2022
@JeanMeche

JeanMeche commented Dec 24, 2022

Copy link
Copy Markdown
Member

The styleguide example isn't used anymore, there is a PR to remove it : #48587
There is also another one that removes all empty ngOnInit() & constructor from the documentation: #48576

jessicajaniuk
jessicajaniuk approved these changes Jan 5, 2023
View reviewed changes

@jessicajaniuk jessicajaniuk left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: fw-core, public-api

@jessicajaniuk
jessicajaniuk removed their request for review January 5, 2023 01:09
@pullapprove
pullapprove Bot requested a review from dylhunn January 5, 2023 01:10
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 5, 2023
@pkozlowski-opensource

pkozlowski-opensource commented Jan 6, 2023

Copy link
Copy Markdown
Member

Thnx for the info @JeanMeche - closing as a duplicate of #48587 / #48576

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Feb 6, 2023

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir
@pkozlowski-opensource pkozlowski-opensource Awaiting requested review from pkozlowski-opensource
@dylhunn dylhunn Awaiting requested review from dylhunn
1 more reviewer
@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@aanchal88 @JeanMeche @pkozlowski-opensource @jessicajaniuk