fix(localize): add all TypeScript types to the root level tsconfig#48446
Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Closed
fix(localize): add all TypeScript types to the root level tsconfig#48446alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
alan-agius4
added
target: patch
Contributor
Author
|
Another option would be to use |
alan-agius4
added
the
area: i18n
With this change we add all types from the builders tsconfig file to the root level tsconfig when running `ng add @angular/localize`. This is needed as by adding `@angular/localize` type to the root level tsconfig we exclude all other types in `@types` from being included in the IDE tsconfig which results in bad DX. More information on how the `types` option works can be found here: https://www.typescriptlang.org/tsconfig#types Closes angular#48434
alan-agius4
force-pushed
the
ng-add-localize-ide-fix
branch
from
36eab70 to
508e73c
Compare
alan-agius4
added
action: cleanup
AndrewKushnir
approved these changes
Dec 13, 2022
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Thanks for creating this PR, the changes look good to me 👍
@clydin could you please take a look as well (you may have more context on ng add schematics)?
clydin
approved these changes
Dec 14, 2022
alan-agius4
added
action: cleanup
Contributor
Author
|
Superseded by #48502 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we add all types from the builders tsconfig file to the root level tsconfig when running
ng add @angular/localize. This is needed as by adding@angular/localizetype to the root level tsconfig we exclude all other types in@typesfrom being included in the IDE tsconfig which results in bad DX.More information on how the
typesoption works can be found here: https://www.typescriptlang.org/tsconfig#typesCloses #48434